Changeset 56742

Timestamp:

09/29/2023 10:18:05 AM (15 months ago)

Author:

spacedmonkey

Message:

Editor: Replace property_exists calls in block related functions with instanceof

Replace calls to property_exists with instanceof WP_Block_Type in block related functions. This change not only improves type safety but also enhances performance.

Follow on from [56678] and [56677].

Props gziolo, aristath, aaronrobertshaw, spacedmonkey.
Fixes #59453

Location:

trunk/src/wp-includes

Files:

• block-supports/border.php (modified) (1 diff)
• block-supports/colors.php (modified) (1 diff)
• block-supports/typography.php (modified) (2 diffs)
• class-wp-block-supports.php (modified) (1 diff)

trunk/src/wp-includes/block-supports/border.php

@@ -153 +153 @@
 function wp_has_border_feature_support( $block_type, $feature, $default_value = false ) {
     // Check if all border support features have been opted into via `"__experimentalBorder": true`.
-    if ( property_exists( $block_type, 'supports' ) ) {
+    if ( $block_type instanceof WP_Block_Type ) {
         $block_type_supports_border = isset( $block_type->supports['__experimentalBorder'] )
             ? $block_type->supports['__experimentalBorder']

trunk/src/wp-includes/block-supports/colors.php

@@ -18 +18 @@
 function wp_register_colors_support( $block_type ) {
     $color_support = false;
-    if ( property_exists( $block_type, 'supports' ) ) {
+    if ( $block_type instanceof WP_Block_Type ) {
         $color_support = isset( $block_type->supports['color'] ) ? $block_type->supports['color'] : false;
     }

trunk/src/wp-includes/block-supports/typography.php

@@ -17 +17 @@
  */
 function wp_register_typography_support( $block_type ) {
-    if ( ! property_exists( $block_type, 'supports' ) ) {
+    if ( ! ( $block_type instanceof WP_Block_Type ) ) {
         return;
     }
@@ -86 +86 @@
  */
 function wp_apply_typography_support( $block_type, $block_attributes ) {
-    if ( ! property_exists( $block_type, 'supports' ) ) {
+    if ( ! ( $block_type instanceof WP_Block_Type ) ) {
         return array();
     }

trunk/src/wp-includes/class-wp-block-supports.php

@@ -143 +143 @@
         $registered_block_types = $block_registry->get_all_registered();
         foreach ( $registered_block_types as $block_type ) {
-            if ( ! property_exists( $block_type, 'supports' ) ) {
+            if ( ! ( $block_type instanceof WP_Block_Type ) ) {
                 continue;
             }