Make WordPress Core

Changeset 56742


Ignore:
Timestamp:
09/29/2023 10:18:05 AM (8 months ago)
Author:
spacedmonkey
Message:

Editor: Replace property_exists calls in block related functions with instanceof

Replace calls to property_exists with instanceof WP_Block_Type in block related functions. This change not only improves type safety but also enhances performance.

Follow on from [56678] and [56677].

Props gziolo, aristath, aaronrobertshaw, spacedmonkey.
Fixes #59453

Location:
trunk/src/wp-includes
Files:
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-includes/block-supports/border.php

    r56709 r56742  
    153153function wp_has_border_feature_support( $block_type, $feature, $default_value = false ) {
    154154    // Check if all border support features have been opted into via `"__experimentalBorder": true`.
    155     if ( property_exists( $block_type, 'supports' ) ) {
     155    if ( $block_type instanceof WP_Block_Type ) {
    156156        $block_type_supports_border = isset( $block_type->supports['__experimentalBorder'] )
    157157            ? $block_type->supports['__experimentalBorder']
  • trunk/src/wp-includes/block-supports/colors.php

    r56709 r56742  
    1818function wp_register_colors_support( $block_type ) {
    1919    $color_support = false;
    20     if ( property_exists( $block_type, 'supports' ) ) {
     20    if ( $block_type instanceof WP_Block_Type ) {
    2121        $color_support = isset( $block_type->supports['color'] ) ? $block_type->supports['color'] : false;
    2222    }
  • trunk/src/wp-includes/block-supports/typography.php

    r56709 r56742  
    1717 */
    1818function wp_register_typography_support( $block_type ) {
    19     if ( ! property_exists( $block_type, 'supports' ) ) {
     19    if ( ! ( $block_type instanceof WP_Block_Type ) ) {
    2020        return;
    2121    }
     
    8686 */
    8787function wp_apply_typography_support( $block_type, $block_attributes ) {
    88     if ( ! property_exists( $block_type, 'supports' ) ) {
     88    if ( ! ( $block_type instanceof WP_Block_Type ) ) {
    8989        return array();
    9090    }
  • trunk/src/wp-includes/class-wp-block-supports.php

    r55732 r56742  
    143143        $registered_block_types = $block_registry->get_all_registered();
    144144        foreach ( $registered_block_types as $block_type ) {
    145             if ( ! property_exists( $block_type, 'supports' ) ) {
     145            if ( ! ( $block_type instanceof WP_Block_Type ) ) {
    146146                continue;
    147147            }
Note: See TracChangeset for help on using the changeset viewer.