Changeset 56746 for trunk/tests/phpunit/tests/meta.php

Timestamp:

09/29/2023 03:22:12 PM (3 years ago)

Author:

jorbin

Message:

Tests: Reduce usage of assertEquals

Replaces assertSame with assertCount in a number of tests.

Props ayeshrajans, jorbin.
See #58956.

File:

• trunk/tests/phpunit/tests/meta.php (modified) (2 diffs)

trunk/tests/phpunit/tests/meta.php

@@ -152 +152 @@
 
                 // Test EXISTS and NOT EXISTS together, no users should be found.
-                $this->assertSame(
+                $this->assertCount(
                         0,
-                        count(
-                                get_users(
-                                        array(
-                                                'meta_query' => array(
-                                                        array(
-                                                                'key'     => 'meta_key',
-                                                                'compare' => 'NOT EXISTS',
-                                                        ),
-                                                        array(
-                                                                'key'     => 'delete_meta_key',
-                                                                'compare' => 'EXISTS',
-                                                        ),
+                        get_users(
+                                array(
+                                        'meta_query' => array(
+                                                array(
+                                                        'key'     => 'meta_key',
+                                                        'compare' => 'NOT EXISTS',
                                                 ),
-                                        )
+                                                array(
+                                                        'key'     => 'delete_meta_key',
+                                                        'compare' => 'EXISTS',
+                                                ),
+                                        ),
                                 )
                         )
                 );
 
-                $this->assertSame(
+                $this->assertCount(
                         2,
-                        count(
-                                get_users(
-                                        array(
-                                                'meta_query' => array(
-                                                        array(
-                                                                'key'     => 'non_existing_meta',
-                                                                'compare' => 'NOT EXISTS',
-                                                        ),
+                        get_users(
+                                array(
+                                        'meta_query' => array(
+                                                array(
+                                                        'key'     => 'non_existing_meta',
+                                                        'compare' => 'NOT EXISTS',
                                                 ),
-                                        )
+                                        ),
                                 )
                         )
@@ -190 +186 @@
                 delete_metadata( 'user', $this->author->ID, 'meta_key' );
 
-                $this->assertSame(
+                $this->assertCount(
                         2,
-                        count(
-                                get_users(
-                                        array(
-                                                'meta_query' => array(
-                                                        array(
-                                                                'key'     => 'meta_key',
-                                                                'compare' => 'NOT EXISTS',
-                                                        ),
+                        get_users(
+                                array(
+                                        'meta_query' => array(
+                                                array(
+                                                        'key'     => 'meta_key',
+                                                        'compare' => 'NOT EXISTS',
                                                 ),
-                                        )
+                                        ),
                                 )
                         )