Make WordPress Core


Ignore:
Timestamp:
09/29/2023 07:45:53 PM (9 months ago)
Author:
westonruter
Message:

Script Loader: Harden removal of script tag wrappers.

  • Add wp_remove_surrounding_empty_script_tags() to more precisely remove script tag wrappers and warn when doing it wrong.
  • Add clarifying comments for XML escaping logic in wp_get_inline_script_tag().
  • Leverage WP_HTML_Tag_Processor in test_remove_frameless_preview_messenger_channel.
  • Reuse assertEqualMarkup in test_blocking_dependent_with_delayed_dependency.
  • Normalize whitespace in parse_markup_fragment for assertEqualMarkup.

Follow-up to [56687].
Props dmsnell, westonruter, flixos90.
See #58664.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-includes/theme-templates.php

    r56687 r56748  
    206206    </script>
    207207    <?php
    208     $skip_link_script = str_replace( array( '<script>', '</script>' ), '', ob_get_clean() );
     208    $skip_link_script = wp_remove_surrounding_empty_script_tags( ob_get_clean() );
    209209    $script_handle    = 'wp-block-template-skip-link';
    210210    wp_register_script( $script_handle, false );
Note: See TracChangeset for help on using the changeset viewer.