Changeset 56748 for trunk/src/wp-includes/theme-templates.php

Timestamp:

09/29/2023 07:45:53 PM (14 months ago)

Author:

westonruter

Message:

Script Loader: Harden removal of script tag wrappers.

• Add wp_remove_surrounding_empty_script_tags() to more precisely remove script tag wrappers and warn when doing it wrong.
• Add clarifying comments for XML escaping logic in wp_get_inline_script_tag().
• Leverage WP_HTML_Tag_Processor in test_remove_frameless_preview_messenger_channel.
• Reuse assertEqualMarkup in test_blocking_dependent_with_delayed_dependency.
• Normalize whitespace in parse_markup_fragment for assertEqualMarkup.

Follow-up to [56687].
Props dmsnell, westonruter, flixos90.
See #58664.

File:

• trunk/src/wp-includes/theme-templates.php (modified) (1 diff)

trunk/src/wp-includes/theme-templates.php

@@ -206 +206 @@
     </script>
     <?php
-    $skip_link_script = str_replace( array( '<script>', '</script>' ), '', ob_get_clean() );
+    $skip_link_script = wp_remove_surrounding_empty_script_tags( ob_get_clean() );
     $script_handle    = 'wp-block-template-skip-link';
     wp_register_script( $script_handle, false );