Changeset 56748 for trunk/tests/phpunit/tests/customize/manager.php

Timestamp:

09/29/2023 07:45:53 PM (19 months ago)

Author:

westonruter

Message:

Script Loader: Harden removal of script tag wrappers.

• Add wp_remove_surrounding_empty_script_tags() to more precisely remove script tag wrappers and warn when doing it wrong.
• Add clarifying comments for XML escaping logic in wp_get_inline_script_tag().
• Leverage WP_HTML_Tag_Processor in test_remove_frameless_preview_messenger_channel.
• Reuse assertEqualMarkup in test_blocking_dependent_with_delayed_dependency.
• Normalize whitespace in parse_markup_fragment for assertEqualMarkup.

Follow-up to [56687].
Props dmsnell, westonruter, flixos90.
See #58664.

File:

• trunk/tests/phpunit/tests/customize/manager.php (modified) (1 diff)

trunk/tests/phpunit/tests/customize/manager.php

@@ -3136 +3136 @@
         ob_start();
         $manager->remove_frameless_preview_messenger_channel();
-        $output = ob_get_clean();
-        $this->assertStringContainsString( '<script', $output );
+        $processor = new WP_HTML_Tag_Processor( ob_get_clean() );
+        $this->assertTrue( $processor->next_tag( 'script' ), 'Failed to find expected SCRIPT element in output.' );
     }