Changeset 56753

Timestamp:

10/02/2023 11:25:35 AM (3 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Remove redundant ignore annotations, take 5.

The VariableAnalysis standard is not used by WP Core.

Follow-up to [50958], [51003], [52049], [52051], [52069], [53072], [54132], [55132], [56363], [56738], [56743], [56751], [56752].

Props jrf.
See #59161.

Location:

trunk/src/wp-includes

Files:

• block-supports/dimensions.php (modified) (1 diff)
• blocks.php (modified) (1 diff)
• class-wp-theme-json-schema.php (modified) (1 diff)
• functions.php (modified) (1 diff)
• html-api/class-wp-html-open-elements.php (modified) (4 diffs)
• rest-api/endpoints/class-wp-rest-global-styles-controller.php (modified) (2 diffs)
• rest-api/endpoints/class-wp-rest-pattern-directory-controller.php (modified) (1 diff)
• rest-api/endpoints/class-wp-rest-templates-controller.php (modified) (1 diff)

trunk/src/wp-includes/block-supports/dimensions.php

@@ -51 +51 @@
  * @return array Block dimensions CSS classes and inline styles.
  */
-function wp_apply_dimensions_support( $block_type, $block_attributes ) { // phpcs:ignore VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedVariable
+function wp_apply_dimensions_support( $block_type, $block_attributes ) {
         if ( wp_should_skip_block_supports_serialization( $block_type, 'dimensions' ) ) {
                 return array();

trunk/src/wp-includes/blocks.php

@@ -550 +550 @@
                          * @return string Returns the block content.
                          */
-                        $settings['render_callback'] = static function ( $attributes, $content, $block ) use ( $template_path ) { // phpcs:ignore VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedVariable
+                        $settings['render_callback'] = static function ( $attributes, $content, $block ) use ( $template_path ) {
                                 ob_start();
                                 require $template_path;

trunk/src/wp-includes/class-wp-theme-json-schema.php

@@ -141 +141 @@
          */
         private static function unset_setting_by_path( &$settings, $path ) {
-                $tmp_settings = &$settings; // phpcs:ignore VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedVariable
+                $tmp_settings = &$settings;
                 $last_key     = array_pop( $path );
                 foreach ( $path as $key ) {

trunk/src/wp-includes/functions.php

@@ -5080 +5080 @@
                         $input_array[ $path_element ] = array();
                 }
-                $input_array = &$input_array[ $path_element ]; // phpcs:ignore VariableAnalysis.CodeAnalysis.VariableAnalysis.VariableRedeclaration
+                $input_array = &$input_array[ $path_element ];
         }
 

trunk/src/wp-includes/html-api/class-wp-html-open-elements.php

@@ -111 +111 @@
          * @return bool Whether the element was found in a specific scope.
          */
-        public function has_element_in_specific_scope( $tag_name, $termination_list ) { // phpcs:ignore VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedVariable
+        public function has_element_in_specific_scope( $tag_name, $termination_list ) {
                 foreach ( $this->walk_up() as $node ) {
                         if ( $node->node_name === $tag_name ) {
@@ -168 +168 @@
          * @return bool Whether given element is in scope.
          */
-        public function has_element_in_list_item_scope( $tag_name ) { // phpcs:ignore VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedVariable
+        public function has_element_in_list_item_scope( $tag_name ) {
                 throw new WP_HTML_Unsupported_Exception( 'Cannot process elements depending on list item scope.' );
 
@@ -200 +200 @@
          * @return bool Whether given element is in scope.
          */
-        public function has_element_in_table_scope( $tag_name ) { // phpcs:ignore VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedVariable
+        public function has_element_in_table_scope( $tag_name ) {
                 throw new WP_HTML_Unsupported_Exception( 'Cannot process elements depending on table scope.' );
 
@@ -218 +218 @@
          * @return bool Whether given element is in scope.
          */
-        public function has_element_in_select_scope( $tag_name ) { // phpcs:ignore VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedVariable
+        public function has_element_in_select_scope( $tag_name ) {
                 throw new WP_HTML_Unsupported_Exception( 'Cannot process elements depending on select scope.' );
 

trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-global-styles-controller.php

@@ -359 +359 @@
          * @return WP_REST_Response Response object.
          */
-        public function prepare_item_for_response( $post, $request ) { // phpcs:ignore VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedVariable
+        public function prepare_item_for_response( $post, $request ) {
                 $raw_config                       = json_decode( $post->post_content, true );
                 $is_global_styles_user_theme_json = isset( $raw_config['isGlobalStylesUserThemeJSON'] ) && true === $raw_config['isGlobalStylesUserThemeJSON'];
@@ -642 +642 @@
          * @return true|WP_Error True if the request has read access for the item, WP_Error object otherwise.
          */
-        public function get_theme_items_permissions_check( $request ) { // phpcs:ignore VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedVariable
+        public function get_theme_items_permissions_check( $request ) {
                 /*
                  * Verify if the current user has edit_theme_options capability.

trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-pattern-directory-controller.php

@@ -107 +107 @@
 
                 $query_args['locale']             = get_user_locale();
-                $query_args['wp-version']         = $wp_version; // phpcs:ignore VariableAnalysis.CodeAnalysis.VariableAnalysis.UndefinedVariable -- it's defined in `version.php` above.
+                $query_args['wp-version']         = $wp_version;
                 $query_args['pattern-categories'] = isset( $request['category'] ) ? $request['category'] : false;
                 $query_args['pattern-keywords']   = isset( $request['keyword'] ) ? $request['keyword'] : false;

trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-templates-controller.php

@@ -634 +634 @@
          * @return WP_REST_Response Response object.
          */
-        public function prepare_item_for_response( $item, $request ) { // phpcs:ignore VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedVariable
+        public function prepare_item_for_response( $item, $request ) {
                 // Restores the more descriptive, specific name for use within this method.
                 $template = $item;