Changeset 56763 for trunk/src/wp-includes/class-wp-query.php

Timestamp:

10/03/2023 02:59:22 PM (18 months ago)

Author:

spacedmonkey

Message:

Query: Improve caching behavior for WP_Query when retrieving id=>parent fields

In [53941], the addition of query caching to WP_Query brought about an unintended issue when querying for fields equal to id=>parent. Specifically, on websites with object caching enabled and a substantial number of pages, the second run of this query triggered the _prime_post_caches function for id=>parent. This led to the unnecessary priming of post, meta, and term caches, even when only id and parent information were requested.

This commit addresses this issue by introducing a new function, _prime_post_parents_caches, which primes a dedicated cache for post parents. This cache is primed during the initial query execution. Subsequently, the wp_cache_get_multiple function is employed to retrieve all post parent data in a single object cache request, optimizing performance.

Additionally, this commit extends the coverage of existing unit tests to ensure the reliability of the changes.

Props kevinfodness, joemcgill, peterwilsoncc, LinSoftware, thekt12, spacedmonkey.
Fixes #59188

File:

• trunk/src/wp-includes/class-wp-query.php (modified) (2 diffs)

trunk/src/wp-includes/class-wp-query.php

@@ -3180 +3180 @@
 
                 if ( $cached_results ) {
-                    if ( 'ids' === $q['fields'] ) {
-                        /** @var int[] */
-                        $this->posts = array_map( 'intval', $cached_results['posts'] );
-                    } else {
-                        _prime_post_caches( $cached_results['posts'], $q['update_post_term_cache'], $q['update_post_meta_cache'] );
-                        /** @var WP_Post[] */
-                        $this->posts = array_map( 'get_post', $cached_results['posts'] );
-                    }
-
-                    $this->post_count    = count( $this->posts );
+                    /** @var int[] */
+                    $post_ids = array_map( 'intval', $cached_results['posts'] );
+
+                    $this->post_count    = count( $post_ids );
                     $this->found_posts   = $cached_results['found_posts'];
                     $this->max_num_pages = $cached_results['max_num_pages'];
 
                     if ( 'ids' === $q['fields'] ) {
+                        $this->posts = $post_ids;
+
                         return $this->posts;
                     } elseif ( 'id=>parent' === $q['fields'] ) {
+                        _prime_post_parents_caches( $post_ids );
+
                         /** @var int[] */
-                        $post_parents = array();
-
-                        foreach ( $this->posts as $key => $post ) {
+                        $post_parents = wp_cache_get_multiple( $post_ids, 'post_parent' );
+
+                        foreach ( $post_parents as $id => $post_parent ) {
                             $obj              = new stdClass();
-                            $obj->ID          = (int) $post->ID;
-                            $obj->post_parent = (int) $post->post_parent;
-
-                            $this->posts[ $key ] = $obj;
-
-                            $post_parents[ $obj->ID ] = $obj->post_parent;
+                            $obj->ID          = (int) $id;
+                            $obj->post_parent = (int) $post_parent;
+
+                            $this->posts[] = $obj;
                         }
 
                         return $post_parents;
+                    } else {
+                        _prime_post_caches( $post_ids, $q['update_post_term_cache'], $q['update_post_meta_cache'] );
+                        /** @var WP_Post[] */
+                        $this->posts = array_map( 'get_post', $post_ids );
                     }
                 }
@@ -3257 +3257 @@
                 $post_ids[]                      = (int) $post->ID;
             }
+            // Prime post parent caches, so that on second run, there is not another database query.
+            wp_cache_add_multiple( $post_parents, 'post_parent' );
 
             if ( $q['cache_results'] && $id_query_is_cacheable ) {