Changeset 56765 for trunk/src/wp-admin/includes/theme.php

Timestamp:

10/03/2023 03:16:55 PM (2 years ago)

Author:

spacedmonkey

Message:

Editor: Improve performance of _register_theme_block_patterns function.

The _register_theme_block_patterns function imposed a significant resource overhead. This issue primarily stems from themes, such as TT4, that register a substantial number of block patterns. These patterns necessitate numerous file operations, including file lookups, file reading into memory, and related processes. To provide an overview, the _register_theme_block_patterns function performed the following file operations:

• is_dir
• is_readable
• file_exists
• glob
• file_get_contents (utilized via get_file_data)

To address these issues, caching using a transient has been added to a new function call _wp_get_block_patterns. If theme development mode is disabled and theme exists, the block patterns are saved in a transient cache. This cache is used all requests after that, saving file lookups and reading files into memory. Cache invalidation is done, when themes are switched, deleted or updated. Meaning that block patterns are not stored in the cache incorrectly.

Props flixos90, joemcgill, peterwilsoncc, costdev, swissspidy, aristath, westonruter, spacedmonkey.
Fixes #59490

File:

• trunk/src/wp-admin/includes/theme.php (modified) (2 diffs)

trunk/src/wp-admin/includes/theme.php

@@ -82 +82 @@
     do_action( 'delete_theme', $stylesheet );
 
+    $theme = wp_get_theme( $stylesheet );
+
     $themes_dir = trailingslashit( $themes_dir );
     $theme_dir  = trailingslashit( $themes_dir . $stylesheet );
@@ -125 +127 @@
         WP_Theme::network_disable_theme( $stylesheet );
     }
+
+    // Clear theme caches.
+    $theme->cache_delete();
 
     // Force refresh of theme update information.