Changeset 56805 for trunk/tests/phpunit/tests/blocks/getHookedBlocks.php

Timestamp:

10/09/2023 04:38:25 PM (16 months ago)

Author:

Bernhard Reiter

Message:

Blocks: Call get_hooked_blocks only once per template/part/pattern.

Prior to this changeset, get_hooked_blocks was called four times for every parsed block in each template, template part, and pattern. With this changeset applied, get_hooked_blocks is called only once per template, template part, or pattern.

Additionally, get_hooked_blocks is called only once when returning the list of all registered patterns. (The latter modification brings the implementation closer to its state prior to Block Hooks.)

Finally, when there are no registered hooked blocks or hooked_block_types filters, parsing, hooked block insertion, and re-serializing is skipped altogether.

Props gziolo, flixos90, joemcgill, dmsnell, spacedmonkey, hellofromtonya.
Fixes #59383.

File:

• trunk/tests/phpunit/tests/blocks/getHookedBlocks.php (modified) (2 diffs)

trunk/tests/phpunit/tests/blocks/getHookedBlocks.php

@@ -63 +63 @@
      */
     public function test_get_hooked_blocks_no_match_found() {
-        $result = get_hooked_blocks( 'tests/no-hooked-blocks' );
+        $result = get_hooked_blocks();
 
         $this->assertSame( array(), $result );
@@ -99 +99 @@
         $this->assertSame(
             array(
-                'before' => array(
-                    'tests/injected-one',
-                    'tests/injected-two',
+                'tests/hooked-at-before'           => array(
+                    'before' => array(
+                        'tests/injected-one',
+                        'tests/injected-two',
+                    ),
+                ),
+                'tests/hooked-at-after'            => array(
+                    'after' => array(
+                        'tests/injected-one',
+                        'tests/injected-two',
+                    ),
+                ),
+                'tests/hooked-at-before-and-after' => array(
+                    'before' => array(
+                        'tests/injected-one',
+                    ),
+                    'after'  => array(
+                        'tests/injected-two',
+                    ),
+                ),
+                'tests/hooked-at-first-child'      => array(
+                    'first_child' => array(
+                        'tests/injected-two',
+                    ),
+                ),
+                'tests/hooked-at-last-child'       => array(
+                    'last_child' => array(
+                        'tests/injected-two',
+                    ),
                 ),
             ),
-            get_hooked_blocks( 'tests/hooked-at-before' ),
-            'block hooked at the before position'
-        );
-        $this->assertSame(
-            array(
-                'after' => array(
-                    'tests/injected-one',
-                    'tests/injected-two',
-                ),
-            ),
-            get_hooked_blocks( 'tests/hooked-at-after' ),
-            'block hooked at the after position'
-        );
-        $this->assertSame(
-            array(
-                'first_child' => array(
-                    'tests/injected-two',
-                ),
-            ),
-            get_hooked_blocks( 'tests/hooked-at-first-child' ),
-            'block hooked at the first child position'
-        );
-        $this->assertSame(
-            array(
-                'last_child' => array(
-                    'tests/injected-two',
-                ),
-            ),
-            get_hooked_blocks( 'tests/hooked-at-last-child' ),
-            'block hooked at the last child position'
-        );
-        $this->assertSame(
-            array(
-                'before' => array(
-                    'tests/injected-one',
-                ),
-                'after'  => array(
-                    'tests/injected-two',
-                ),
-            ),
-            get_hooked_blocks( 'tests/hooked-at-before-and-after' ),
-            'block hooked before one block and after another'
+            get_hooked_blocks()
         );
     }