Changeset 56811

Timestamp:

10/09/2023 11:01:15 PM (11 months ago)

Author:

peterwilsoncc

Message:

Query: Rename _prime_post_parents_caches() for clarity.

Change the name of _prime_post_parents_caches() to _prime_post_parent_id_caches() to make it clearer only the parent post ID is cached rather than the entire post parent object.

Follow up to [56763].

Props spacedmonkey, joemcgill, peterwilsoncc.
See #59188.

Location:

trunk

Files:

• src/wp-includes/class-wp-query.php (modified) (1 diff)
• src/wp-includes/post.php (modified) (2 diffs)
• tests/phpunit/tests/post/primePostParentsCaches.php (modified) (10 diffs)

trunk/src/wp-includes/class-wp-query.php

@@ -3192 +3192 @@
                         return $this->posts;
                     } elseif ( 'id=>parent' === $q['fields'] ) {
-                        _prime_post_parents_caches( $post_ids );
+                        _prime_post_parent_id_caches( $post_ids );
 
                         /** @var int[] */

trunk/src/wp-includes/post.php

@@ -7798 +7798 @@
 
 /**
- * Prime post parent caches.
+ * Prime the cache containing the parent ID of various post objects.
  *
  * @global wpdb $wpdb WordPress database abstraction object.
@@ -7806 +7806 @@
  * @param int[] $ids ID list.
  */
-function _prime_post_parents_caches( array $ids ) {
+function _prime_post_parent_id_caches( array $ids ) {
     global $wpdb;
 

trunk/tests/phpunit/tests/post/primePostParentsCaches.php

@@ -1 +1 @@
 <?php
 /**
- * Test `_prime_post_parents_caches()`.
+ * Test `_prime_post_parent_id_caches()`.
  *
  * @package WordPress
@@ -7 +7 @@
 
 /**
- * Test class for `_prime_post_parents_caches()`.
+ * Test class for `_prime_post_parent_id_caches()`.
  *
  * @group post
  * @group cache
  *
- * @covers ::_prime_post_parents_caches
+ * @covers ::_prime_post_parent_id_caches
  */
-class Tests_Post_PrimePostParentsCaches extends WP_UnitTestCase {
+class Tests_Post_PrimePostParentIdCaches extends WP_UnitTestCase {
 
     /**
@@ -35 +35 @@
      * @ticket 59188
      */
-    public function test_prime_post_parents_caches() {
+    public function test_prime_post_parent_id_caches() {
         $post_id = self::$posts[0];
 
         $before_num_queries = get_num_queries();
-        _prime_post_parents_caches( array( $post_id ) );
+        _prime_post_parent_id_caches( array( $post_id ) );
         $num_queries = get_num_queries() - $before_num_queries;
 
@@ -49 +49 @@
      * @ticket 59188
      */
-    public function test_prime_post_parents_caches_multiple() {
+    public function test_prime_post_parent_id_caches_multiple() {
         $before_num_queries = get_num_queries();
-        _prime_post_parents_caches( self::$posts );
+        _prime_post_parent_id_caches( self::$posts );
         $num_queries = get_num_queries() - $before_num_queries;
 
@@ -61 +61 @@
      * @ticket 59188
      */
-    public function test_prime_post_parents_caches_multiple_runs() {
-        _prime_post_parents_caches( self::$posts );
+    public function test_prime_post_parent_id_caches_multiple_runs() {
+        _prime_post_parent_id_caches( self::$posts );
         $before_num_queries = get_num_queries();
-        _prime_post_parents_caches( self::$posts );
+        _prime_post_parent_id_caches( self::$posts );
         $num_queries = get_num_queries() - $before_num_queries;
 
@@ -73 +73 @@
      * @ticket 59188
      */
-    public function test_prime_post_parents_caches_update() {
+    public function test_prime_post_parent_id_caches_update() {
         $page_id            = self::factory()->post->create(
             array(
@@ -81 +81 @@
         );
         $before_num_queries = get_num_queries();
-        _prime_post_parents_caches( array( $page_id ) );
+        _prime_post_parent_id_caches( array( $page_id ) );
         $num_queries = get_num_queries() - $before_num_queries;
 
@@ -95 +95 @@
 
         $before_num_queries = get_num_queries();
-        _prime_post_parents_caches( array( $page_id ) );
+        _prime_post_parent_id_caches( array( $page_id ) );
         $num_queries = get_num_queries() - $before_num_queries;
 
@@ -105 +105 @@
      * @ticket 59188
      */
-    public function test_prime_post_parents_caches_delete() {
+    public function test_prime_post_parent_id_caches_delete() {
         $parent_page_id     = self::factory()->post->create(
             array(
@@ -118 +118 @@
         );
         $before_num_queries = get_num_queries();
-        _prime_post_parents_caches( array( $page_id ) );
+        _prime_post_parent_id_caches( array( $page_id ) );
         $num_queries = get_num_queries() - $before_num_queries;