Changeset 56827

Timestamp:

10/11/2023 12:15:18 PM (17 months ago)

Author:

desrosj

Message:

Build/Test Tools: Don’t send Slack notification for workflow retries.

[56780] changed Slack failure notifications to not send a failure notification during the first run of a workflow. Because workflows automatically restart once, a failure during the first run can be ignored.

This adjusts the workflow to also not send a “fixed” notification when the second run of a workflow succeeds after a failure. Because the original failure is no longer reported, these notifications are unnecessary.

See #58867.

File:

• trunk/.github/workflows/slack-notifications.yml (modified) (1 diff)

trunk/.github/workflows/slack-notifications.yml

@@ -76 +76 @@
             }
 
-            // When a workflow has been restarted to fix a failure, check the previous run attempt.
-            if ( workflow_run.data.run_attempt > 1 ) {
+            // When a workflow has been restarted, check the previous run attempt. Because workflows are automatically
+            // restarted once and a failure on the first run is not reported, failures on the second run should not be
+            // considered.
+            if ( workflow_run.data.run_attempt > 2 ) {
               const previous_run = await github.rest.actions.getWorkflowRunAttempt({
                 owner: context.repo.owner,