Changeset 56828

Timestamp:

10/11/2023 03:14:01 PM (15 months ago)

Author:

flixos90

Message:

Editor: Add further test coverage for wp_render_elements_support().

Props dmsnell, aaronrobertshaw.
Fixes #59578.

Location:

trunk

Files:

• src/wp-includes/block-supports/elements.php (modified) (1 diff)
• tests/phpunit/tests/block-supports/wpRenderElementsSupport.php (modified) (3 diffs)

trunk/src/wp-includes/block-supports/elements.php

@@ -37 +37 @@
 
     $block_type = WP_Block_Type_Registry::get_instance()->get_registered( $block['blockName'] );
+    if ( ! $block_type ) {
+        return $block_content;
+    }
 
     $element_color_properties = array(

trunk/tests/phpunit/tests/block-supports/wpRenderElementsSupport.php

@@ -17 +17 @@
         $this->test_block_name = null;
         parent::tear_down();
+    }
+
+    /**
+     * Tests that block supports leaves block content alone if the block type
+     * isn't registered.
+     *
+     * @ticket 59578
+     *
+     * @covers ::wp_render_elements_support
+     *
+     * @return void
+     */
+    public function test_leaves_block_content_alone_when_block_type_not_registered() {
+        $block = array(
+            'blockName' => 'test/element-block-supports',
+            'attrs'     => array(
+                'style' => array(
+                    'elements' => array(
+                        'button' => array(
+                            'color' => array(
+                                'text'       => 'var:preset|color|vivid-red',
+                                'background' => '#fff',
+                            ),
+                        ),
+                    ),
+                ),
+            ),
+        );
+
+        $block_markup = '<p>Hello <a href="http://www.wordpress.org/">WordPress</a>!</p>';
+        $actual       = wp_render_elements_support( $block_markup, $block );
+
+        $this->assertSame( $block_markup, $actual, 'Expected to leave block content unmodified, but found changes.' );
     }
 
@@ -65 +98 @@
             $expected_markup,
             $actual,
-            'Position block wrapper markup should be correct'
+            'Block wrapper markup should be correct'
         );
     }
@@ -81 +114 @@
 
         return array(
+            // @ticket 59578
+            'empty block markup remains untouched'         => array(
+                'color_settings'  => array(
+                    'button' => true,
+                ),
+                'elements_styles' => array(
+                    'button' => array( 'color' => $color_styles ),
+                ),
+                'block_markup'    => '',
+                'expected_markup' => '/^$/',
+            ),
+            'empty block markup remains untouched when no block attributes' => array(
+                'color_settings'  => array(
+                    'button' => true,
+                ),
+                'elements_styles' => null,
+                'block_markup'    => '',
+                'expected_markup' => '/^$/',
+            ),
+            'block markup remains untouched when block has no attributes' => array(
+                'color_settings'  => array(
+                    'button' => true,
+                ),
+                'elements_styles' => null,
+                'block_markup'    => '<p>Hello <a href="http://www.wordpress.org/">WordPress</a>!</p>',
+                'expected_markup' => '/^<p>Hello <a href="http:\/\/www.wordpress.org\/">WordPress<\/a>!<\/p>$/',
+            ),
+            // @ticket 5418
             'button element styles with serialization skipped' => array(
                 'color_settings'  => array(