Changeset 56843

Timestamp:

10/12/2023 01:22:17 PM (14 months ago)

Author:

audrasjb

Message:

Comments: Prevent users who can not see a post from seeing comments on it.

Props peterwilsoncc, jorbin, audrasjb.
Merges [56836] to the 6.3 branch.

Location:

branches/6.3

Files:

• . (modified) (1 prop)
• src/wp-admin/includes/class-wp-comments-list-table.php (modified) (1 diff)
• src/wp-admin/includes/class-wp-list-table.php (modified) (1 diff)
• src/wp-admin/includes/dashboard.php (modified) (1 diff)

branches/6.3/src/wp-admin/includes/class-wp-comments-list-table.php

@@ -651 +651 @@
 
         $this->user_can = current_user_can( 'edit_comment', $comment->comment_ID );
+
+        $edit_post_cap = $post ? 'edit_post' : 'edit_posts';
+        if (
+            current_user_can( $edit_post_cap, $comment->comment_post_ID ) ||
+            (
+                empty( $post->post_password ) &&
+                current_user_can( 'read_post', $comment->comment_post_ID )
+            )
+        ) {
+            // The user has access to the post
+        } else {
+            return false;
+        }
 
         echo "<tr id='comment-$comment->comment_ID' class='$the_comment_class'>";

branches/6.3/src/wp-admin/includes/class-wp-list-table.php

@@ -818 +818 @@
             $pending_comments_number
         );
+
+        $post_object   = get_post( $post_id );
+        $edit_post_cap = $post_object ? 'edit_post' : 'edit_posts';
+        if (
+            current_user_can( $edit_post_cap, $post_id ) ||
+            (
+                empty( $post_object->post_password ) &&
+                current_user_can( 'read_post', $post_id )
+            )
+        ) {
+            // The user has access to the post and thus can see comments
+        } else {
+            return false;
+        }
 
         if ( ! $approved_comments && ! $pending_comments ) {

branches/6.3/src/wp-admin/includes/dashboard.php

@@ -1104 +1104 @@
         echo '<ul id="the-comment-list" data-wp-lists="list:comment">';
         foreach ( $comments as $comment ) {
-            _wp_dashboard_recent_comments_row( $comment );
+            $comment_post = get_post( $comment->comment_post_ID );
+            if (
+                current_user_can( 'edit_post', $comment->comment_post_ID ) ||
+                (
+                    empty( $comment_post->post_password ) &&
+                    current_user_can( 'read_post', $comment->comment_post_ID )
+                )
+            ) {
+                _wp_dashboard_recent_comments_row( $comment );
+            }
         }
         echo '</ul>';