Changeset 56850 for branches/4.1/src/wp-admin/includes/ajax-actions.php

Timestamp:

10/12/2023 02:21:47 PM (3 years ago)

Author:

davidbaumwald

Message:

Grouped backports to the 4.1 branch.

• Comments: Prevent users who can not see a post from seeing comments on it.
• Shortcodes: Restrict ajax handler for media shortcode.
• Prevent unintended behavior when certain objects are unserialized.

Merges [56835], [56836], and [56838] to the 4.1 branch.
Props xknown, jorbin, joehoyle, peterwilsoncc, ehtis, tykoted, antpb.

File:

• branches/4.1/src/wp-admin/includes/ajax-actions.php (modified) (3 diffs)

branches/4.1/src/wp-admin/includes/ajax-actions.php

@@ -829 +829 @@
                 wp_die( 0 );
         }
-        
+
         if ( ! current_user_can( $tax->cap->assign_terms ) ) {
                 wp_die( -1 );
@@ -2768 +2768 @@
         }
 
-        setup_postdata( $post );
-        $shortcode = do_shortcode( wp_unslash( $_POST['shortcode'] ) );
+        $shortcode = wp_unslash( $_POST['shortcode'] );
+
+        // Only process previews for media related shortcodes:
+        $found_shortcodes = get_shortcode_tags_in_content( $shortcode );
+        $media_shortcodes = array(
+                'audio',
+                'embed',
+                'playlist',
+                'video',
+                'gallery',
+        );
+
+        $other_shortcodes = array_diff( $found_shortcodes, $media_shortcodes );
+
+        if ( ! empty( $other_shortcodes ) ) {
+                wp_send_json_error();
+        }
+
+        if ( ! empty( $_POST['post_ID'] ) ) {
+                $post = get_post( (int) $_POST['post_ID'] );
+        }
+
+        // the embed shortcode requires a post
+        if ( ! $post || ! current_user_can( 'edit_post', $post->ID ) ) {
+                if ( in_array( 'embed', $found_shortcodes, true ) ) {
+                        wp_send_json_error();
+                }
+        } else {
+                setup_postdata( $post );
+        }
 
         if ( empty( $shortcode ) ) {
@@ -2836 +2864 @@
         } else {
                 $sessions->destroy_all();
-                /* translators: 1: User's display name. */ 
+                /* translators: 1: User's display name. */
                 $message = sprintf( __( '%s has been logged out.' ), $user->display_name );
         }