Changeset 56850 for branches/4.1/src/wp-admin/includes/class-wp-list-table.php

Timestamp:

10/12/2023 02:21:47 PM (3 years ago)

Author:

davidbaumwald

Message:

Grouped backports to the 4.1 branch.

• Comments: Prevent users who can not see a post from seeing comments on it.
• Shortcodes: Restrict ajax handler for media shortcode.
• Prevent unintended behavior when certain objects are unserialized.

Merges [56835], [56836], and [56838] to the 4.1 branch.
Props xknown, jorbin, joehoyle, peterwilsoncc, ehtis, tykoted, antpb.

File:

• branches/4.1/src/wp-admin/includes/class-wp-list-table.php (modified) (1 diff)

branches/4.1/src/wp-admin/includes/class-wp-list-table.php

@@ -574 +574 @@
                 $pending_phrase = sprintf( __( '%s pending' ), number_format( $pending_comments ) );
 
+                $post_object   = get_post( $post_id );
+                $edit_post_cap = $post_object ? 'edit_post' : 'edit_posts';
+                if (
+                        current_user_can( $edit_post_cap, $post_id ) ||
+                        (
+                                empty( $post_object->post_password ) &&
+                                current_user_can( 'read_post', $post_id )
+                        )
+                ) {
+                        // The user has access to the post and thus can see comments
+                } else {
+                        return false;
+                }
+
                 if ( $pending_comments )
                         echo '<strong>';