Changeset 56855 for branches/4.4/src/wp-admin/includes/ajax-actions.php

Timestamp:

10/12/2023 02:31:27 PM (3 years ago)

Author:

davidbaumwald

Message:

Grouped backports to the 4.4 branch.

• Comments: Prevent users who can not see a post from seeing comments on it.
• Shortcodes: Restrict media shortcode ajax to certain type.
• REST API: Ensure no-cache headers are sent when methods are overridden.
• Prevent unintended behavior when certain objects are unserialized.

Merges [56834], [56835], [56836], and [56838] to the 4.4 branch.
Props xknown, jorbin, joehoyle, timothyblynjacobs, peterwilsoncc, ehtis, tykoted, antpb, rmccue.

File:

• branches/4.4/src/wp-admin/includes/ajax-actions.php (modified) (2 diffs)

branches/4.4/src/wp-admin/includes/ajax-actions.php

@@ -2981 +2981 @@
     $shortcode = wp_unslash( $_POST['shortcode'] );
 
+    // Only process previews for media related shortcodes:
+    $found_shortcodes = get_shortcode_tags_in_content( $shortcode );
+    $media_shortcodes = array(
+        'audio',
+        'embed',
+        'playlist',
+        'video',
+        'gallery',
+    );
+
+    $other_shortcodes = array_diff( $found_shortcodes, $media_shortcodes );
+
+    if ( ! empty( $other_shortcodes ) ) {
+        wp_send_json_error();
+    }
+
     if ( ! empty( $_POST['post_ID'] ) ) {
         $post = get_post( (int) $_POST['post_ID'] );
@@ -2987 +3003 @@
     // the embed shortcode requires a post
     if ( ! $post || ! current_user_can( 'edit_post', $post->ID ) ) {
-        if ( 'embed' === $shortcode ) {
+        if ( in_array( 'embed', $found_shortcodes, true ) ) {
             wp_send_json_error();
         }