Make WordPress Core


Ignore:
Timestamp:
10/12/2023 02:51:26 PM (6 months ago)
Author:
davidbaumwald
Message:

Grouped backports to the 4.9 branch.

  • Comments: Prevent users who can not see a post from seeing comments on it.
  • Shortcodes: Restrict media shortcode ajax to certain type.
  • REST API: Ensure no-cache headers are sent when methods are overridden.
  • REST API: Limit search_columns for users without list_users.
  • Prevent unintended behavior when certain objects are unserialized.

Merges [56834], [56835], [56836], [56838], and [56840] to the 4.9 branch.
Props xknown, jorbin, joehoyle, timothyblynjacobs, peterwilsoncc, ehtis, tykoted, antpb, rmccue.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • branches/4.9/src/wp-admin/includes/ajax-actions.php

    r55787 r56865  
    31413141    $shortcode = wp_unslash( $_POST['shortcode'] );
    31423142
     3143    // Only process previews for media related shortcodes:
     3144    $found_shortcodes = get_shortcode_tags_in_content( $shortcode );
     3145    $media_shortcodes = array(
     3146        'audio',
     3147        'embed',
     3148        'playlist',
     3149        'video',
     3150        'gallery',
     3151    );
     3152
     3153    $other_shortcodes = array_diff( $found_shortcodes, $media_shortcodes );
     3154
     3155    if ( ! empty( $other_shortcodes ) ) {
     3156        wp_send_json_error();
     3157    }
     3158
    31433159    if ( ! empty( $_POST['post_ID'] ) ) {
    31443160        $post = get_post( (int) $_POST['post_ID'] );
     
    31473163    // the embed shortcode requires a post
    31483164    if ( ! $post || ! current_user_can( 'edit_post', $post->ID ) ) {
    3149         if ( 'embed' === $shortcode ) {
     3165        if ( in_array( 'embed', $found_shortcodes, true ) ) {
    31503166            wp_send_json_error();
    31513167        }
Note: See TracChangeset for help on using the changeset viewer.