Changeset 56871 for branches/5.0/src/wp-admin/includes/class-wp-list-table.php

Timestamp:

10/12/2023 02:59:28 PM (3 years ago)

Author:

davidbaumwald

Message:

Grouped backports to the 5.0 branch.

• Comments: Prevent users who can not see a post from seeing comments on it.
• Shortcodes: Restrict media shortcode ajax to certain type.
• REST API: Ensure no-cache headers are sent when methods are overridden.
• REST API: Limit search_columns for users without list_users.
• Prevent unintended behavior when certain objects are unserialized.

Merges [56833], [56834], [56835], [56836], and [56838] to the 5.0 branch.
Props xknown, jorbin, joehoyle, timothyblynjacobs, peterwilsoncc, ehtis, tykoted, antpb, rmccue.

File:

• branches/5.0/src/wp-admin/includes/class-wp-list-table.php (modified) (1 diff)

branches/5.0/src/wp-admin/includes/class-wp-list-table.php

@@ -623 +623 @@
         $pending_phrase = sprintf( _n( '%s pending comment', '%s pending comments', $pending_comments ), $pending_comments_number );
 
-        // No comments at all.
+        $post_object   = get_post( $post_id );
+        $edit_post_cap = $post_object ? 'edit_post' : 'edit_posts';
+        if (
+            current_user_can( $edit_post_cap, $post_id ) ||
+            (
+                empty( $post_object->post_password ) &&
+                current_user_can( 'read_post', $post_id )
+            )
+        ) {
+            // The user has access to the post and thus can see comments
+        } else {
+            return false;
+        }
+
         if ( ! $approved_comments && ! $pending_comments ) {
             printf( '<span aria-hidden="true">&#8212;</span><span class="screen-reader-text">%s</span>',