Changeset 56873 for branches/5.1/src/wp-includes/class-wp-theme.php

Timestamp:

10/12/2023 03:02:41 PM (2 years ago)

Author:

davidbaumwald

Message:

Grouped backports to the 5.1 branch.

• Comments: Prevent users who can not see a post from seeing comments on it.
• Shortcodes: Restrict media shortcode ajax to certain type.
• REST API: Ensure no-cache headers are sent when methods are overridden.
• REST API: Limit search_columns for users without list_users.
• Prevent unintended behavior when certain objects are unserialized.

Merges [56833], [56834], [56835], [56836], and [56838] to the 5.1 branch.
Props xknown, jorbin, joehoyle, timothyblynjacobs, peterwilsoncc, ehtis, tykoted, antpb, rmccue.

Location:

branches/5.1

Files:

• . (modified) (1 prop)
• src/wp-includes/class-wp-theme.php (modified) (2 diffs)

branches/5.1/src/wp-includes/class-wp-theme.php

@@ -628 +628 @@
 
     /**
+     * Perform reinitialization tasks.
+     *
+     * Prevents a callback from being injected during unserialization of an object.
+     *
+     * @return void
+     */
+    public function __wakeup() {
+        if ( $this->parent && ! $this->parent instanceof self ) {
+            throw new UnexpectedValueException();
+        }
+        if ( $this->headers && ! is_array( $this->headers ) ) {
+            throw new UnexpectedValueException();
+        }
+        foreach ( $this->headers as $value ) {
+            if ( ! is_string( $value ) ) {
+                throw new UnexpectedValueException();
+            }
+        }
+        $this->headers_sanitized = array();
+    }
+
+    /**
      * Adds theme data to cache.
      *
@@ -1605 +1627 @@
         return strnatcasecmp( $a->name_translated, $b->name_translated );
     }
+
+    private static function _check_headers_property_has_correct_type( $headers ) {
+        if ( ! is_array( $headers ) ) {
+            return false;
+        }
+        foreach ( $headers as $key => $value ) {
+            if ( ! is_string( $key ) || ! is_string( $value ) ) {
+                return false;
+            }
+        }
+        return true;
+    }
 }