Changeset 56875 for branches/5.9/src/wp-admin/includes/class-wp-list-table.php

Timestamp:

10/12/2023 03:03:26 PM (18 months ago)

Author:

joemcgill

Message:

Grouped backports to the 5.9 branch.

• REST API: Limit search_columns for users without list_users.
• Comments: Prevent users who can not see a post from seeing comments on it.
• Application Passwords: Prevent the use of some pseudo protocols in application passwords.
• Restrict media shortcode ajax to certain type
• REST API: Ensure no-cache headers are sent when methods are overriden.
• Prevent unintended behavior when certain objects are unserialized.

Merges [56833], [56834], [56835], [56836], [56837], and [56838] to the 5.9 branch.
Props xknown, jorbin, Vortfu, joehoyle, timothyblynjacobs, peterwilsoncc, ehtis, tykoted, martinkrcho, paulkevan, dd32, antpb, rmccue.

Location:

branches/5.9

Files:

• . (modified) (1 prop)
• src/wp-admin/includes/class-wp-list-table.php (modified) (1 diff)

branches/5.9/src/wp-admin/includes/class-wp-list-table.php

@@ -739 +739 @@
             $pending_comments_number
         );
+
+        $post_object   = get_post( $post_id );
+        $edit_post_cap = $post_object ? 'edit_post' : 'edit_posts';
+        if (
+            current_user_can( $edit_post_cap, $post_id ) ||
+            (
+                empty( $post_object->post_password ) &&
+                current_user_can( 'read_post', $post_id )
+            )
+        ) {
+            // The user has access to the post and thus can see comments
+        } else {
+            return false;
+        }
 
         if ( ! $approved_comments && ! $pending_comments ) {