Changeset 56878 for branches/5.4/src/wp-admin/includes/class-wp-comments-list-table.php

Timestamp:

10/12/2023 03:06:49 PM (3 years ago)

Author:

davidbaumwald

Message:

Grouped backports to the 5.4 branch.

• Comments: Prevent users who can not see a post from seeing comments on it.
• Shortcodes: Restrict media shortcode ajax to certain type.
• REST API: Ensure no-cache headers are sent when methods are overridden.
• REST API: Limit search_columns for users without list_users.
• Prevent unintended behavior when certain objects are unserialized.

Merges [56833], [56834], [56835], [56836], and [56838] to the 5.4 branch.
Props xknown, jorbin, joehoyle, timothyblynjacobs, peterwilsoncc, ehtis, tykoted, antpb, rmccue.

Location:

branches/5.4

Files:

• . (modified) (1 prop)
• src/wp-admin/includes/class-wp-comments-list-table.php (modified) (1 diff)

branches/5.4/src/wp-admin/includes/class-wp-comments-list-table.php

@@ -562 +562 @@
                 $this->user_can = current_user_can( 'edit_comment', $comment->comment_ID );
 
+                $edit_post_cap = $post ? 'edit_post' : 'edit_posts';
+                if (
+                        current_user_can( $edit_post_cap, $comment->comment_post_ID ) ||
+                        (
+                                empty( $post->post_password ) &&
+                                current_user_can( 'read_post', $comment->comment_post_ID )
+                        )
+                ) {
+                        // The user has access to the post
+                } else {
+                        return false;
+                }
+
                 echo "<tr id='comment-$comment->comment_ID' class='$the_comment_class'>";
                 $this->single_row_columns( $comment );