Make WordPress Core


Ignore:
Timestamp:
10/12/2023 03:12:09 PM (8 months ago)
Author:
davidbaumwald
Message:

Grouped backports to the 5.6 branch.

  • Comments: Prevent users who can not see a post from seeing comments on it.
  • Shortcodes: Restrict media shortcode ajax to certain type.
  • REST API: Ensure no-cache headers are sent when methods are overridden.
  • REST API: Limit search_columns for users without list_users.
  • Prevent unintended behavior when certain objects are unserialized.
  • Application Passwords: Prevent the use of some pseudo protocols in application passwords.

Merges [56833], [56834], [56835], [56836], [56837], and [56838] to the 5.6 branch.
Props xknown, jorbin, Vortfu, joehoyle, timothyblynjacobs, peterwilsoncc, ehtis, tykoted, martinkrcho, paulkevan, dd32, antpb, rmccue.

Location:
branches/5.6
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • branches/5.6

  • branches/5.6/src/wp-admin/includes/ajax-actions.php

    r55781 r56882  
    37673767    $shortcode = wp_unslash( $_POST['shortcode'] );
    37683768
     3769    // Only process previews for media related shortcodes:
     3770    $found_shortcodes = get_shortcode_tags_in_content( $shortcode );
     3771    $media_shortcodes = array(
     3772        'audio',
     3773        'embed',
     3774        'playlist',
     3775        'video',
     3776        'gallery',
     3777    );
     3778
     3779    $other_shortcodes = array_diff( $found_shortcodes, $media_shortcodes );
     3780
     3781    if ( ! empty( $other_shortcodes ) ) {
     3782        wp_send_json_error();
     3783    }
     3784
    37693785    if ( ! empty( $_POST['post_ID'] ) ) {
    37703786        $post = get_post( (int) $_POST['post_ID'] );
     
    37733789    // The embed shortcode requires a post.
    37743790    if ( ! $post || ! current_user_can( 'edit_post', $post->ID ) ) {
    3775         if ( 'embed' === $shortcode ) {
     3791        if ( in_array( 'embed', $found_shortcodes, true ) ) {
    37763792            wp_send_json_error();
    37773793        }
Note: See TracChangeset for help on using the changeset viewer.