Changeset 56896 for trunk/src/wp-includes/class-wp-block-patterns-registry.php

Timestamp:

10/12/2023 04:39:27 PM (21 months ago)

Author:

Bernhard Reiter

Message:

Patterns: Don't inject theme attribute on frontend.

Having the patterns registry inject the theme attribute into all Template Part blocks inside every pattern was found to negatively impact performance. It turns out that it's only required for the editor (i.e. in the REST API) but not on the frontend; there, it's instead possible to fall back to the currently active theme.

The latter change was made to the Pattern and Template Part blocks in ​https://github.com/WordPress/gutenberg/pull/55217, which was sync'ed to Core in [56849]. Consequently, this changeset removes theme attribute insertion from the frontend.

Props flixos90, gziolo, dmsnell, hellofromtonya.
Fixes #59583.

File:

• trunk/src/wp-includes/class-wp-block-patterns-registry.php (modified) (2 diffs)

trunk/src/wp-includes/class-wp-block-patterns-registry.php

@@ -166 +166 @@
         $content = $pattern['content'];
 
-        $before_block_visitor = '_inject_theme_attribute_in_template_part_block';
+        $before_block_visitor = ( defined( 'REST_REQUEST' ) && REST_REQUEST ) ? '_inject_theme_attribute_in_template_part_block' : null;
         $after_block_visitor  = null;
         if ( ! empty( $hooked_blocks ) || has_filter( 'hooked_block_types' ) ) {
@@ -172 +172 @@
             $after_block_visitor  = make_after_block_visitor( $hooked_blocks, $pattern );
         }
-        $blocks  = parse_blocks( $content );
-        $content = traverse_and_serialize_blocks( $blocks, $before_block_visitor, $after_block_visitor );
+        if ( null !== $before_block_visitor || null !== $after_block_visitor ) {
+            $blocks  = parse_blocks( $content );
+            $content = traverse_and_serialize_blocks( $blocks, $before_block_visitor, $after_block_visitor );
+        }
 
         return $content;