Changeset 56896 for trunk/tests/phpunit/tests/blocks/wpBlockPatternsRegistry.php

Timestamp:

10/12/2023 04:39:27 PM (18 months ago)

Author:

Bernhard Reiter

Message:

Patterns: Don't inject theme attribute on frontend.

Having the patterns registry inject the theme attribute into all Template Part blocks inside every pattern was found to negatively impact performance. It turns out that it's only required for the editor (i.e. in the REST API) but not on the frontend; there, it's instead possible to fall back to the currently active theme.

The latter change was made to the Pattern and Template Part blocks in ​https://github.com/WordPress/gutenberg/pull/55217, which was sync'ed to Core in [56849]. Consequently, this changeset removes theme attribute insertion from the frontend.

Props flixos90, gziolo, dmsnell, hellofromtonya.
Fixes #59583.

File:

• trunk/tests/phpunit/tests/blocks/wpBlockPatternsRegistry.php (modified) (2 diffs)

trunk/tests/phpunit/tests/blocks/wpBlockPatternsRegistry.php

@@ -318 +318 @@
 
     /**
-     * Should insert a theme attribute into Template Part blocks in registered patterns.
-     *
-     * @ticket 59583
-     *
-     * @covers WP_Block_Patterns_Registry::register
-     * @covers WP_Block_Patterns_Registry::get_all_registered
-     */
-    public function test_get_all_registered_includes_theme_attribute() {
-        $test_pattern = array(
-            'title'   => 'Test Pattern',
-            'content' => '<!-- wp:template-part {"slug":"header","align":"full","tagName":"header","className":"site-header"} /-->',
-        );
-        $this->registry->register( 'test/pattern', $test_pattern );
-
-        $expected = sprintf(
-            '<!-- wp:template-part {"slug":"header","align":"full","tagName":"header","className":"site-header","theme":"%s"} /-->',
-            get_stylesheet()
-        );
-        $patterns = $this->registry->get_all_registered();
-        $this->assertSame( $expected, $patterns[0]['content'] );
-    }
-
-    /**
      * Should insert hooked blocks into registered patterns.
      *
@@ -393 +370 @@
 
     /**
-     * Should insert a theme attribute into Template Part blocks in registered patterns.
-     *
-     * @ticket 59583
-     *
-     * @covers WP_Block_Patterns_Registry::register
-     * @covers WP_Block_Patterns_Registry::get_registered
-     */
-    public function test_get_registered_includes_theme_attribute() {
-        $test_pattern = array(
-            'title'   => 'Test Pattern',
-            'content' => '<!-- wp:template-part {"slug":"header","align":"full","tagName":"header","className":"site-header"} /-->',
-        );
-        $this->registry->register( 'test/pattern', $test_pattern );
-
-        $expected = sprintf(
-            '<!-- wp:template-part {"slug":"header","align":"full","tagName":"header","className":"site-header","theme":"%s"} /-->',
-            get_stylesheet()
-        );
-        $pattern  = $this->registry->get_registered( 'test/pattern' );
-        $this->assertSame( $expected, $pattern['content'] );
-    }
-
-    /**
      * Should insert hooked blocks into registered patterns.
      *