Changeset 56925 for trunk/src/wp-includes/class-wp-query.php

Timestamp:

10/12/2023 11:39:05 PM (19 months ago)

Author:

peterwilsoncc

Message:

Query: Cache post parent IDs in posts group.

Move the cache of post parent IDs from the dedicated group post_parents to posts. This maintains backward compatibility for clearing all post object related data by calling wp_cache_flush_group( 'posts' ).

Post parent IDs are now cached with with the prefix post_parent: in the posts group.

Follow up to [56763].

Props spacedmonkey, joemcgill, peterwilsoncc.
See #59188.

File:

• trunk/src/wp-includes/class-wp-query.php (modified) (3 diffs)

trunk/src/wp-includes/class-wp-query.php

@@ -3193 +3193 @@
                         _prime_post_parent_id_caches( $post_ids );
 
+                        $post_parent_cache_keys = array();
+                        foreach ( $post_ids as $post_id ) {
+                            $post_parent_cache_keys[] = 'post_parent:' . (string) $post_id;
+                        }
+
                         /** @var int[] */
-                        $post_parents = wp_cache_get_multiple( $post_ids, 'post_parent' );
-
-                        foreach ( $post_parents as $id => $post_parent ) {
+                        $post_parents = wp_cache_get_multiple( $post_parent_cache_keys, 'posts' );
+
+                        foreach ( $post_parents as $cache_key => $post_parent ) {
                             $obj              = new stdClass();
-                            $obj->ID          = (int) $id;
+                            $obj->ID          = (int) str_replace( 'post_parent:', '', $cache_key );
                             $obj->post_parent = (int) $post_parent;
 
@@ -3246 +3251 @@
 
             /** @var int[] */
-            $post_parents = array();
-            $post_ids     = array();
+            $post_parents       = array();
+            $post_ids           = array();
+            $post_parents_cache = array();
 
             foreach ( $this->posts as $key => $post ) {
@@ -3255 +3261 @@
                 $post_parents[ (int) $post->ID ] = (int) $post->post_parent;
                 $post_ids[]                      = (int) $post->ID;
+
+                $post_parents_cache[ 'post_parent:' . (string) $post->ID ] = (int) $post->post_parent;
             }
             // Prime post parent caches, so that on second run, there is not another database query.
-            wp_cache_add_multiple( $post_parents, 'post_parent' );
+            wp_cache_add_multiple( $post_parents_cache, 'posts' );
 
             if ( $q['cache_results'] && $id_query_is_cacheable ) {