Make WordPress Core

Changeset 56938


Ignore:
Timestamp:
10/15/2023 02:53:12 PM (6 months ago)
Author:
hellofromTonya
Message:

Code Modernization: Declare dynamic properties on WP_Text_Diff_Renderer_Table.

Core uses 3 known, named, dynamic properties on the WP_Text_Diff_Renderer_Table class:

  • _title
  • _title_left
  • _title_right

When reviewing revisions (within the admin UI), wp_text_diff() passes the arguments (without the leading _) to a new instance, which raised deprecation notices (see [56354]).

Note: the parent class adds the leading _ to each of these properties (see [7747]).

The deprecation notices are resolved by declaring each of these known, named, dynamic properties on the class, per the #56034 mitigation strategy. These new properties are not initialized to retain their previous null behavior.

Follow-up to [56354], [23506], [7747].

Props wildworks, antonvlasenko, hellofromTonya, ironprogrammer, kafleg, mukesh27, nicolefurlan, presskopp, sabernhardt.
Fixes #59431.
See #58898, #56034.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-includes/class-wp-text-diff-renderer-table.php

    r56548 r56938  
    3030     */
    3131    public $_trailing_context_lines = 10000;
     32
     33    /**
     34     * Title of the item being compared.
     35     *
     36     * @since 6.4.0 Declared a previously dynamic property.
     37     * @var string|null
     38     */
     39    public $_title;
     40
     41    /**
     42     * Title for the left column.
     43     *
     44     * @since 6.4.0 Declared a previously dynamic property.
     45     * @var string|null
     46     */
     47    public $_title_left;
     48
     49    /**
     50     * Title for the right column.
     51     *
     52     * @since 6.4.0 Declared a previously dynamic property.
     53     * @var string|null
     54     */
     55    public $_title_right;
    3256
    3357    /**
Note: See TracChangeset for help on using the changeset viewer.