Changeset 56954

Timestamp:

10/17/2023 11:27:24 AM (16 months ago)

Author:

swissspidy

Message:

Build/Test Tools: Reinstate PUPPETEER_SKIP_DOWNLOAD for most CI workflows.

The PUPPETEER_SKIP_DOWNLOAD environment variable is used to prevent Puppeteer from automatically downloading browser binaries.
It was removed in [56926] due to the migration to Playwright. However, because of the QUnit tests, Puppeteer is actually still a dependency.

Until those tests change, we have to keep this environment variable to prevent unnecessary downloads on CI.

Props SergeyBiryukov.
Fixes #59517.

Location:

trunk/.github/workflows

Files:

• coding-standards.yml (modified) (1 diff)
• end-to-end-tests.yml (modified) (1 diff)
• performance.yml (modified) (1 diff)
• phpunit-tests-run.yml (modified) (1 diff)
• test-coverage.yml (modified) (1 diff)
• test-npm.yml (modified) (1 diff)

trunk/.github/workflows/coding-standards.yml

@@ -143 +143 @@
     timeout-minutes: 20
     if: ${{ github.repository == 'WordPress/wordpress-develop' || github.event_name == 'pull_request' }}
+    env:
+      PUPPETEER_SKIP_DOWNLOAD: ${{ true }}
 
     steps:

trunk/.github/workflows/end-to-end-tests.yml

@@ -33 +33 @@
 env:
   LOCAL_DIR: build
+  PUPPETEER_SKIP_DOWNLOAD: ${{ true }}
 
 jobs:

trunk/.github/workflows/performance.yml

@@ -31 +31 @@
 
 env:
+  PUPPETEER_SKIP_DOWNLOAD: ${{ true }}
+
   # Performance testing should be performed in an environment reflecting a standard production environment.
   LOCAL_WP_DEBUG: false

trunk/.github/workflows/phpunit-tests-run.yml

@@ -52 +52 @@
   LOCAL_PHP_MEMCACHED: ${{ inputs.memcached }}
   PHPUNIT_CONFIG: ${{ inputs.phpunit-config }}
+  PUPPETEER_SKIP_DOWNLOAD: ${{ true }}
 
 jobs:

trunk/.github/workflows/test-coverage.yml

@@ -34 +34 @@
   LOCAL_PHP_XDEBUG_MODE: 'coverage'
   LOCAL_PHP_MEMCACHED: ${{ false }}
+  PUPPETEER_SKIP_DOWNLOAD: ${{ true }}
 
 jobs:

trunk/.github/workflows/test-npm.yml

@@ -38 +38 @@
 permissions: {}
 
+env:
+  PUPPETEER_SKIP_DOWNLOAD: ${{ true }}
+
 jobs:
   # Verifies that installing npm dependencies and building WordPress works as expected.