Changeset 56960 for trunk/tests/phpunit/tests/blocks/wpBlockPatternsRegistry.php

Timestamp:

10/17/2023 03:46:44 PM (11 months ago)

Author:

Bernhard Reiter

Message:

Patterns, Templates: Inject theme attr into Template Part blocks.

It was found that Template Part blocks were broken in the Site Editor, showing the Template part has been deleted or is unavailable message, due to a missing theme attribute.

This bug seems to have been introduced by [56896], whose goal was to only inject that attribute into the markup returned by the templates and patterns REST API endpoints but not on the frontend, in order to improve performance. It has been demonstrated locally that reverting that changeset fixes the bug.

Reverts [56896].
Props mmcalister, swisspidy, thelovelist, hellofromTonya, pbiron, Pauthake015, richtabor, nicolefurlan, huzaifaalmesbah, annezazu, kafleg, aegkr, sunitarai, shresthaaman, andraganescu, onemaggie, gziolo.
Fixes #59629.

File:

• trunk/tests/phpunit/tests/blocks/wpBlockPatternsRegistry.php (modified) (2 diffs)

trunk/tests/phpunit/tests/blocks/wpBlockPatternsRegistry.php

@@ -318 +318 @@
 
     /**
+     * Should insert a theme attribute into Template Part blocks in registered patterns.
+     *
+     * @ticket 59583
+     *
+     * @covers WP_Block_Patterns_Registry::register
+     * @covers WP_Block_Patterns_Registry::get_all_registered
+     */
+    public function test_get_all_registered_includes_theme_attribute() {
+        $test_pattern = array(
+            'title'   => 'Test Pattern',
+            'content' => '<!-- wp:template-part {"slug":"header","align":"full","tagName":"header","className":"site-header"} /-->',
+        );
+        $this->registry->register( 'test/pattern', $test_pattern );
+
+        $expected = sprintf(
+            '<!-- wp:template-part {"slug":"header","align":"full","tagName":"header","className":"site-header","theme":"%s"} /-->',
+            get_stylesheet()
+        );
+        $patterns = $this->registry->get_all_registered();
+        $this->assertSame( $expected, $patterns[0]['content'] );
+    }
+
+    /**
      * Should insert hooked blocks into registered patterns.
      *
@@ -370 +393 @@
 
     /**
+     * Should insert a theme attribute into Template Part blocks in registered patterns.
+     *
+     * @ticket 59583
+     *
+     * @covers WP_Block_Patterns_Registry::register
+     * @covers WP_Block_Patterns_Registry::get_registered
+     */
+    public function test_get_registered_includes_theme_attribute() {
+        $test_pattern = array(
+            'title'   => 'Test Pattern',
+            'content' => '<!-- wp:template-part {"slug":"header","align":"full","tagName":"header","className":"site-header"} /-->',
+        );
+        $this->registry->register( 'test/pattern', $test_pattern );
+
+        $expected = sprintf(
+            '<!-- wp:template-part {"slug":"header","align":"full","tagName":"header","className":"site-header","theme":"%s"} /-->',
+            get_stylesheet()
+        );
+        $pattern  = $this->registry->get_registered( 'test/pattern' );
+        $this->assertSame( $expected, $pattern['content'] );
+    }
+
+    /**
      * Should insert hooked blocks into registered patterns.
      *