Changeset 56979 for branches/6.4/tests/phpunit/tests/theme/wpGetGlobalStylesheet.php

Timestamp:

10/20/2023 07:33:59 PM (14 months ago)

Author:

joemcgill

Message:

Themes: Make caches for block patterns clearable.

In [56765], theme block pattern files were cached to a transient as a performance enhancement. However, transients are not easily clearable when caches are flushed on environments not using a persistent cache, which can lead to errors if the theme files are renamed, edited, or moved.

This changes the caching mechanism to use wp_cache_set() instead, and caches these values to the global group so they are still persistent on environments using an object cache, and will be cleared by a cache flush.

In addition, the helper _wp_get_block_patterns has been moved WP_Theme::get_block_patterns for consistency with other block related theme methods and cache helpers for these values, WP_Theme::get_pattern_cache and WP_Theme::set_pattern_cache, have been made private.

Relevant unit tests updated.

Props afercia, flixos90, mukesh27, joemcgill.
Merges [56978] to the 6.4 branch.
Fixes #59633. See #59591, #59490.

Location:

branches/6.4

Files:

• . (modified) (1 prop)
• tests/phpunit/tests/theme/wpGetGlobalStylesheet.php (modified) (1 diff)

branches/6.4/tests/phpunit/tests/theme/wpGetGlobalStylesheet.php

@@ -27 +27 @@
 
     public function tear_down() {
+        // Reset development mode after each test.
+        unset( $GLOBALS['_wp_tests_development_mode'] );
+
         // Reset the theme support.
         if ( $this->remove_theme_support_at_teardown ) {