WordPress.org
Get WordPress

Make WordPress Core

Changeset 57000


Ignore:
Timestamp:
10/24/2023 02:12:06 PM (17 months ago)
Author:
desrosj
Message:

Build/Test Tools: Simplify some logic in GitHub Action workflows.

This simplifies the logic within the slack-notifications and failed-workflow steps in GitHub Action workflows to use the contains() function and object filtering.

This makes it simpler to perform the needed checks by removing the need to list out every single dependent job defined in needs.

Merges [56660] to the 6.4 branch.
See #58867.

Location:
branches/6.4/.github/workflows
Files:
9 edited

Legend:

Unmodified
Added
Removed

  • branches/6.4/.github/workflows/coding-standards.yml

    r56954 r57000  
    183183    if: ${{ github.repository == 'WordPress/wordpress-develop' && github.event_name != 'pull_request' && always() }}
    184184    with:
    185       calling_status: ${{ contains( needs.*.result, 'cancelled' ) && 'cancelled' || contains( needs.*.result, 'failure' ) && 'failure' || 'success' }}
     185      calling_status: ${{ needs.phpcs.result == 'success' && needs.jshint.result == 'success' && 'success' || ( needs.phpcs.result == 'cancelled' || needs.jshint.result == 'cancelled' ) && 'cancelled' || 'failure' }}
    186186    secrets:
    187187      SLACK_GHA_SUCCESS_WEBHOOK: ${{ secrets.SLACK_GHA_SUCCESS_WEBHOOK }}
    … …  
    202202      github.run_attempt < 2 &&
    203203      (
    204         contains( needs.*.result, 'cancelled' ) ||
    205         contains( needs.*.result, 'failure' )
     204        needs.phpcs.result == 'cancelled' || needs.phpcs.result == 'failure' ||
     205        needs.jshint.result == 'cancelled' || needs.jshint.result == 'failure'
    206206      )
    207207

  • branches/6.4/.github/workflows/javascript-tests.yml

    r56660 r57000  
    9898    if: ${{ github.repository == 'WordPress/wordpress-develop' && github.event_name != 'pull_request' && always() }}
    9999    with:
    100       calling_status: ${{ contains( needs.*.result, 'cancelled' ) && 'cancelled' || contains( needs.*.result, 'failure' ) && 'failure' || 'success' }}
     100      calling_status: ${{ needs.test-js.result == 'success' && 'success' || needs.test-js.result == 'cancelled' && 'cancelled' || 'failure' }}
    101101    secrets:
    102102      SLACK_GHA_SUCCESS_WEBHOOK: ${{ secrets.SLACK_GHA_SUCCESS_WEBHOOK }}
    … …  
    117117      github.run_attempt < 2 &&
    118118      (
    119         contains( needs.*.result, 'cancelled' ) ||
    120         contains( needs.*.result, 'failure' )
     119        needs.test-js.result == 'cancelled' || needs.test-js.result == 'failure'
    121120      )
    122121

  • branches/6.4/.github/workflows/performance.yml

    r56954 r57000  
    270270    if: ${{ github.repository == 'WordPress/wordpress-develop' && github.event_name != 'pull_request' && always() }}
    271271    with:
    272       calling_status: ${{ contains( needs.*.result, 'cancelled' ) && 'cancelled' || contains( needs.*.result, 'failure' ) && 'failure' || 'success' }}
     272      calling_status: ${{ needs.performance.result == 'success' && 'success' || needs.performance.result == 'cancelled' && 'cancelled' || 'failure' }}
    273273    secrets:
    274274      SLACK_GHA_SUCCESS_WEBHOOK: ${{ secrets.SLACK_GHA_SUCCESS_WEBHOOK }}
    … …  
    289289      github.run_attempt < 2 &&
    290290      (
    291         contains( needs.*.result, 'cancelled' ) ||
    292         contains( needs.*.result, 'failure' )
     291        needs.performance.result == 'cancelled' || needs.performance.result == 'failure'
    293292      )
    294293

  • branches/6.4/.github/workflows/php-compatibility.yml

    r56660 r57000  
    123123    if: ${{ github.repository == 'WordPress/wordpress-develop' && github.event_name != 'pull_request' && always() }}
    124124    with:
    125       calling_status: ${{ contains( needs.*.result, 'cancelled' ) && 'cancelled' || contains( needs.*.result, 'failure' ) && 'failure' || 'success' }}
     125      calling_status: ${{ needs.php-compatibility.result == 'success' && 'success' || needs.php-compatibility.result == 'cancelled' && 'cancelled' || 'failure' }}
    126126    secrets:
    127127      SLACK_GHA_SUCCESS_WEBHOOK: ${{ secrets.SLACK_GHA_SUCCESS_WEBHOOK }}
    … …  
    142142      github.run_attempt < 2 &&
    143143      (
    144         contains( needs.*.result, 'cancelled' ) ||
    145         contains( needs.*.result, 'failure' )
     144        needs.php-compatibility.result == 'cancelled' || needs.php-compatibility.result == 'failure'
    146145      )
    147146

  • branches/6.4/.github/workflows/phpunit-tests.yml

    r56660 r57000  
    137137    if: ${{ github.repository == 'WordPress/wordpress-develop' && github.event_name != 'pull_request' && always() }}
    138138    with:
    139       calling_status: ${{ contains( needs.*.result, 'cancelled' ) && 'cancelled' || contains( needs.*.result, 'failure' ) && 'failure' || 'success' }}
     139      calling_status: ${{ needs.test-with-mysql.result == 'success' && needs.test-with-mariadb.result == 'success' && 'success' || ( needs.test-with-mysql.result == 'cancelled' || needs.test-with-mariadb.result == 'cancelled' ) && 'cancelled' || 'failure' }}
    140140    secrets:
    141141      SLACK_GHA_SUCCESS_WEBHOOK: ${{ secrets.SLACK_GHA_SUCCESS_WEBHOOK }}
    … …  
    156156      github.run_attempt < 2 &&
    157157      (
    158         contains( needs.*.result, 'cancelled' ) ||
    159         contains( needs.*.result, 'failure' )
     158        needs.test-with-mysql.result == 'cancelled' || needs.test-with-mysql.result == 'failure' ||
     159        needs.test-with-mariadb.result == 'cancelled' || needs.test-with-mariadb.result == 'failure'
    160160      )
    161161

  • branches/6.4/.github/workflows/test-and-zip-default-themes.yml

    r56792 r57000  
    203203    if: ${{ github.repository == 'WordPress/wordpress-develop' && github.event_name != 'pull_request' && always() }}
    204204    with:
    205       calling_status: ${{ contains( needs.*.result, 'cancelled' ) && 'cancelled' || contains( needs.*.result, 'failure' ) && 'failure' || 'success' }}
     205      calling_status: ${{ needs.test-build-scripts.result == 'success' && needs.bundle-theme.result == 'success' && 'success' || ( needs.test-build-scripts.result == 'cancelled' || needs.bundle-theme.result == 'cancelled' ) && 'cancelled' || 'failure' }}
    206206    secrets:
    207207      SLACK_GHA_SUCCESS_WEBHOOK: ${{ secrets.SLACK_GHA_SUCCESS_WEBHOOK }}
    … …  
    222222      github.run_attempt < 2 &&
    223223      (
    224         contains( needs.*.result, 'cancelled' ) ||
    225         contains( needs.*.result, 'failure' )
     224        needs.test-build-scripts.result == 'cancelled' || needs.test-build-scripts.result == 'failure' ||
     225        needs.bundle-theme.result == 'cancelled' || needs.bundle-theme.result == 'failure'
    226226      )
    227227

  • branches/6.4/.github/workflows/test-coverage.yml

    r56954 r57000  
    184184    if: ${{ github.repository == 'WordPress/wordpress-develop' && github.event_name != 'pull_request' && always() }}
    185185    with:
    186       calling_status: ${{ contains( needs.*.result, 'cancelled' ) && 'cancelled' || contains( needs.*.result, 'failure' ) && 'failure' || 'success' }}
     186      calling_status: ${{ needs.test-coverage-report.result == 'success' && 'success' || needs.test-coverage-report.result == 'cancelled' && 'cancelled' || 'failure' }}
    187187    secrets:
    188188      SLACK_GHA_SUCCESS_WEBHOOK: ${{ secrets.SLACK_GHA_SUCCESS_WEBHOOK }}
    … …  
    203203      github.run_attempt < 2 &&
    204204      (
    205         contains( needs.*.result, 'cancelled' ) ||
    206         contains( needs.*.result, 'failure' )
     205        needs.test-coverage-report.result == 'cancelled' || needs.test-coverage-report.result == 'failure'
    207206      )
    208207

  • branches/6.4/.github/workflows/test-npm.yml

    r56954 r57000  
    185185    if: ${{ github.repository == 'WordPress/wordpress-develop' && github.event_name != 'pull_request' && always() }}
    186186    with:
    187       calling_status: ${{ contains( needs.*.result, 'cancelled' ) && 'cancelled' || contains( needs.*.result, 'failure' ) && 'failure' || 'success' }}
     187      calling_status: ${{ needs.test-npm.result == 'success' && needs.test-npm-macos.result == 'success' && 'success' || ( needs.test-npm.result == 'cancelled' || needs.test-npm-macos.result == 'cancelled' ) && 'cancelled' || 'failure' }}
    188188    secrets:
    189189      SLACK_GHA_SUCCESS_WEBHOOK: ${{ secrets.SLACK_GHA_SUCCESS_WEBHOOK }}
    … …  
    204204      github.run_attempt < 2 &&
    205205      (
    206         contains( needs.*.result, 'cancelled' ) ||
    207         contains( needs.*.result, 'failure' )
     206        needs.test-npm.result == 'cancelled' || needs.test-npm.result == 'failure' ||
     207        needs.test-npm-macos.result == 'cancelled' || needs.test-npm-macos.result == 'failure'
    208208      )
    209209

  • branches/6.4/.github/workflows/test-old-branches.yml

    r56955 r57000  
    110110    if: ${{ github.repository == 'WordPress/wordpress-develop' && github.event_name != 'pull_request' && always() }}
    111111    with:
    112       calling_status: ${{ contains( needs.*.result, 'cancelled' ) && 'cancelled' || contains( needs.*.result, 'failure' ) && 'failure' || 'success' }}
     112      calling_status: ${{ needs.dispatch-workflows-for-old-branches.result == 'success' && 'success' || needs.dispatch-workflows-for-old-branches.result == 'cancelled' && 'cancelled' || 'failure' }}
    113113    secrets:
    114114      SLACK_GHA_SUCCESS_WEBHOOK: ${{ secrets.SLACK_GHA_SUCCESS_WEBHOOK }}
Note: See TracChangeset for help on using the changeset viewer.