Changeset 57021 for trunk/src/wp-includes/block-patterns.php

Timestamp:

10/27/2023 07:02:54 PM (12 months ago)

Author:

joemcgill

Message:

Upgrade/Install: Skip registering theme block patterns during the upgrade process.

This fixes a bug during the database upgrade process where a theme's functions.php file may not be loaded, leading to potential exceptions if the theme's pattern files use symbols (classes, functions, constants, etc.) that are declared only when the functions.php file is loaded. To do so, a check for wp_get_active_and_valid_themes() is added early to _register_theme_block_patterns(), which returns early if no active or valid themes are returned.

Props fabiankaegy, rajinsharwar, pbiron, huzaifaalmesbah, hellofromTonya, peterwilsoncc, joemcgill.
Fixes #59723.

File:

• trunk/src/wp-includes/block-patterns.php (modified) (1 diff)

trunk/src/wp-includes/block-patterns.php

@@ -329 +329 @@
  */
 function _register_theme_block_patterns() {
+
+    /*
+     * During the bootstrap process, a check for active and valid themes is run.
+     * If no themes are returned, the theme's functions.php file will not be loaded,
+     * which can lead to errors if patterns expect some variables or constants to
+     * already be set at this point, so bail early if that is the case.
+     */
+    if ( empty( wp_get_active_and_valid_themes() ) ) {
+        return;
+    }
+
     /*
      * Register patterns for the active theme. If the theme is a child theme,