Changeset 57030 for branches/6.4/tests/phpunit/tests/option/wpPrimeOptionCachesByGroup.php

Timestamp:

10/30/2023 11:21:03 PM (14 months ago)

Author:

peterwilsoncc

Message:

Options, Meta APIs: Fast follow fixes for option cache priming functions.

A collection of fixes for wp_prime_option_caches():

• cache arrays and objects in their serialized form for consistency with get_option() and wp_load_alloptions()
• prevent repeat database queries for falsey and known non-existent options (notoptions)

Additional tests for wp_prime_option_caches() to ensure:

• additional database queries are not made repriming options (known, known-unknown and alloptions)
• cache is primed consistently
• get_option() returns a consistent value regardless of how it is primed
• database queries do not contain earlier primed options
• get_option does not prime the cache when testing the cache has been successfully primed

Fixes a test for wp_prime_option_caches_by_group() to ensure get_option does not prime the cache when testing the cache has been successfully primed.

Follow up to [56445],[56990],[57013].

Reviewed by flixos90, hellofromTonya, joemcgill.
Merges [57029] to the 6.4 branch.

Props peterwilsoncc, costdev, flixos90, hellofromTonya, mikeschroder, joemcgill.
Fixes #59738. See #58962.

Location:

branches/6.4

Files:

• . (modified) (1 prop)
• tests/phpunit/tests/option/wpPrimeOptionCachesByGroup.php (modified) (1 diff)

branches/6.4/tests/phpunit/tests/option/wpPrimeOptionCachesByGroup.php

@@ -48 +48 @@
         wp_prime_option_caches_by_group( 'group1' );
 
-        // Check that options are now in the cache.
-        $this->assertSame( get_option( 'option1' ), wp_cache_get( 'option1', 'options' ), 'option1\'s cache was not primed.' );
-        $this->assertSame( get_option( 'option2' ), wp_cache_get( 'option2', 'options' ), 'option2\'s cache was not primed.' );
+        /*
+         * Check that options are now in the cache.
+         *
+         * Repeat the string here rather than using get_option as get_option
+         * will prime the cache before the call to wp_cache_get if the option
+         * is not in the cache. Thus causing the tests to pass when they should
+         * fail.
+         */
+        $this->assertSame( 'value_option1', wp_cache_get( 'option1', 'options' ), 'option1\'s cache was not primed.' );
+        $this->assertSame( 'value_option2', wp_cache_get( 'option2', 'options' ), 'option2\'s cache was not primed.' );
 
         // Make sure option3 is still not in cache.