Changeset 57123 for trunk/src/wp-admin/includes/class-wp-list-table.php

Timestamp:

11/17/2023 05:09:09 PM (10 months ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Rewrite a few capability checks for clarity and readability.

This aims to:

• Perform the checks as early as possible to avoid redundant function calls.
• Remove an empty conditiaonal branch and make the exit conditions clearer.
• Bring the formatting in line with other multi-line conditionals in core.

Follow-up to [56836].

See #59650.

File:

• trunk/src/wp-admin/includes/class-wp-list-table.php (modified) (2 diffs)

trunk/src/wp-admin/includes/class-wp-list-table.php

@@ -829 +829 @@
      */
     protected function comments_bubble( $post_id, $pending_comments ) {
+        $post_object   = get_post( $post_id );
+        $edit_post_cap = $post_object ? 'edit_post' : 'edit_posts';
+
+        if ( ! current_user_can( $edit_post_cap, $post_id )
+            && ( ! empty( $post_object->post_password )
+                || ! current_user_can( 'read_post', $post_id ) )
+        ) {
+            // The user has no access to the post and thus cannot see the comments.
+            return false;
+        }
+
         $approved_comments = get_comments_number();
 
@@ -851 +862 @@
             $pending_comments_number
         );
-
-        $post_object   = get_post( $post_id );
-        $edit_post_cap = $post_object ? 'edit_post' : 'edit_posts';
-        if (
-            current_user_can( $edit_post_cap, $post_id ) ||
-            (
-                empty( $post_object->post_password ) &&
-                current_user_can( 'read_post', $post_id )
-            )
-        ) {
-            // The user has access to the post and thus can see comments.
-        } else {
-            return false;
-        }
 
         if ( ! $approved_comments && ! $pending_comments ) {