Make WordPress Core


Ignore:
Timestamp:
11/17/2023 05:09:09 PM (7 months ago)
Author:
SergeyBiryukov
Message:

Coding Standards: Rewrite a few capability checks for clarity and readability.

This aims to:

  • Perform the checks as early as possible to avoid redundant function calls.
  • Remove an empty conditiaonal branch and make the exit conditions clearer.
  • Bring the formatting in line with other multi-line conditionals in core.

Follow-up to [56836].

See #59650.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-admin/includes/class-wp-list-table.php

    r57120 r57123  
    829829     */
    830830    protected function comments_bubble( $post_id, $pending_comments ) {
     831        $post_object   = get_post( $post_id );
     832        $edit_post_cap = $post_object ? 'edit_post' : 'edit_posts';
     833
     834        if ( ! current_user_can( $edit_post_cap, $post_id )
     835            && ( ! empty( $post_object->post_password )
     836                || ! current_user_can( 'read_post', $post_id ) )
     837        ) {
     838            // The user has no access to the post and thus cannot see the comments.
     839            return false;
     840        }
     841
    831842        $approved_comments = get_comments_number();
    832843
     
    851862            $pending_comments_number
    852863        );
    853 
    854         $post_object   = get_post( $post_id );
    855         $edit_post_cap = $post_object ? 'edit_post' : 'edit_posts';
    856         if (
    857             current_user_can( $edit_post_cap, $post_id ) ||
    858             (
    859                 empty( $post_object->post_password ) &&
    860                 current_user_can( 'read_post', $post_id )
    861             )
    862         ) {
    863             // The user has access to the post and thus can see comments.
    864         } else {
    865             return false;
    866         }
    867864
    868865        if ( ! $approved_comments && ! $pending_comments ) {
Note: See TracChangeset for help on using the changeset viewer.