Changeset 57133

Timestamp:

11/23/2023 02:39:16 PM (3 years ago)

Author:

SergeyBiryukov

Message:

Tests: Avoid an infinite loop in Spy_REST_Server if a non-existing method is called.

Follow-up to [34928].

Props xknown, joemcgill.
Fixes #59601.

Location:

trunk/tests/phpunit

Files:

• includes/spy-rest-server.php (modified) (1 diff)
• tests/rest-api.php (modified) (1 diff)

trunk/tests/phpunit/includes/spy-rest-server.php

@@ -26 +26 @@
          */
         public function __call( $method, $args ) {
+                if ( ! method_exists( $this, $method ) ) {
+                        throw new Error( sprintf( 'Call to undefined method %s::%s()', get_class( $this ), $method ) );
+                }
+
                 return call_user_func_array( array( $this, $method ), $args );
         }

trunk/tests/phpunit/tests/rest-api.php

@@ -30 +30 @@
         public function filter_wp_rest_server_class( $class_name ) {
                 return 'Spy_REST_Server';
+        }
+
+        public function test_rest_get_server_fails_with_undefined_method() {
+                $this->expectException( Error::class );
+                rest_get_server()->does_not_exist();
         }