Changeset 57139 for trunk/src/wp-includes/theme.php

Timestamp:

11/27/2023 09:15:56 AM (12 months ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Reorder conditionals in is_random_header_image().

This aims to slightly improve performance by checking the faster empty() language construct first and potentially avoiding an unnecessary function call. Additionally, this better matches a similar conditional a few lines below.

Follow-up to [17757], [17770].

Props Cybr.
See #59650.

File:

• trunk/src/wp-includes/theme.php (modified) (2 diffs)

trunk/src/wp-includes/theme.php

@@ -1438 +1438 @@
         if ( 'random-default-image' === $header_image_mod
             || 'random-uploaded-image' === $header_image_mod
-            || ( '' !== get_random_header_image() && empty( $header_image_mod ) )
+            || ( empty( $header_image_mod ) && '' !== get_random_header_image() )
         ) {
             return true;
@@ -1445 +1445 @@
         if ( "random-$type-image" === $header_image_mod ) {
             return true;
-        } elseif ( 'default' === $type && empty( $header_image_mod ) && '' !== get_random_header_image() ) {
+        } elseif ( 'default' === $type
+            && empty( $header_image_mod ) && '' !== get_random_header_image()
+        ) {
             return true;
         }