Changeset 57170

Timestamp:

12/07/2023 10:55:28 PM (10 months ago)

Author:

flixos90

Message:

General: Avoid early initialization of variable in get_bloginfo().

This is a very minor, yet simple performance optimization in a commonly called function, avoiding unnecessary initialization of the $url variable when it may not be needed. The conditional is simple enough to not use a variable altogether.

Props Cybr, swissspidy.
Fixes #59450.

File:

• trunk/src/wp-includes/general-template.php (modified) (1 diff)

trunk/src/wp-includes/general-template.php

@@ -907 +907 @@
     }
 
-    $url = true;
-
-    if ( ! str_contains( $show, 'url' )
-        && ! str_contains( $show, 'directory' )
-        && ! str_contains( $show, 'home' )
-    ) {
-        $url = false;
-    }
-
     if ( 'display' === $filter ) {
-        if ( $url ) {
+        if (
+            str_contains( $show, 'url' )
+            || str_contains( $show, 'directory' )
+            || str_contains( $show, 'home' )
+        ) {
             /**
              * Filters the URL returned by get_bloginfo().