Changeset 57176

Timestamp:

12/09/2023 10:11:45 PM (10 months ago)

Author:

SergeyBiryukov

Message:

REST API: Pass correct number of arguments to the comment_text filter.

This ensures that WP_REST_Comments_Controller::prepare_item_for_response() passes three arguments to the comment_text filter, for consistency with all the other instances in core.

Follow-up to [15957], [16357], [25555], [38832], [40664].

Props sjregan, SergeyBiryukov.
Fixes #58238.

Location:

trunk

Files:

• src/wp-includes/rest-api/endpoints/class-wp-rest-comments-controller.php (modified) (1 diff)
• tests/phpunit/tests/rest-api/rest-comments-controller.php (modified) (1 diff)

trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-comments-controller.php

@@ -1092 +1092 @@
             $data['content'] = array(
                 /** This filter is documented in wp-includes/comment-template.php */
-                'rendered' => apply_filters( 'comment_text', $comment->comment_content, $comment ),
+                'rendered' => apply_filters( 'comment_text', $comment->comment_content, $comment, array() ),
                 'raw'      => $comment->comment_content,
             );

trunk/tests/phpunit/tests/rest-api/rest-comments-controller.php

@@ -965 +965 @@
             array_keys( $response->get_data() )
         );
+    }
+
+    /**
+     * @ticket 58238
+     */
+    public function test_prepare_item_comment_text_filter() {
+        $filter = new MockAction();
+        add_filter( 'comment_text', array( $filter, 'filter' ), 10, 3 );
+
+        $request = new WP_REST_Request( 'GET', sprintf( '/wp/v2/comments/%d', self::$approved_id ) );
+
+        $response = rest_get_server()->dispatch( $request );
+
+        $this->assertSame( 1, $filter->get_call_count() );
+        $this->assertCount( 3, $filter->get_args()[0] );
     }