Changeset 57185 for trunk/tests/phpunit/tests/dependencies/scripts.php

Timestamp:

12/13/2023 05:48:09 PM (3 years ago)

Author:

jorbin

Message:

External Libraries: For Lodash, sync the declared version number with the one that is loaded.

In [50941] the version of lodash was updated, however the version inside wp_default_packages_vendor was not updated at the same time. This updates the version to correctly reflect the version that is loaded.

Also adds some basic tests for the scripts in wp_default_packages_vendor that match the name of the package from package.json to help prevent errors like this in the future.

Props jadpm, jorbin, swissspidy.
Fixes #60048. See #52991.

File:

• trunk/tests/phpunit/tests/dependencies/scripts.php (modified) (1 diff)

trunk/tests/phpunit/tests/dependencies/scripts.php

@@ -3353 +3353 @@
                 );
         }
+
+        /**
+         * @ticket 60048
+         *
+         * @covers ::wp_default_packages_vendor
+         *
+         * @dataProvider data_wp_default_packages_vendor
+         */
+        public function test_wp_default_packages_vendor_lodash( $script ) {
+                global $wp_scripts;
+                $package_json = $this->_scripts_from_package_json();
+
+                wp_default_packages_vendor( $wp_scripts );
+
+                $this->assertEquals( $package_json[ $script ], $wp_scripts->query( $script, 'registered' )->ver );
+        }
+
+        public function data_wp_default_packages_vendor() {
+                return array(
+                        array( 'script' => 'lodash' ),
+                        array( 'script' => 'moment' ),
+                        array( 'script' => 'react' ),
+                        array( 'script' => 'react-dom' ),
+                        array( 'script' => 'regenerator-runtime' ),
+                );
+        }
+
+        /**
+         * Helper to return dependencies from package.json.
+         */
+        private function _scripts_from_package_json() {
+                $package = file_get_contents( ABSPATH . '../package.json' );
+                $data    = json_decode( $package, true );
+
+                $provider = array();
+                return $data['dependencies'];
+        }
 }