Changeset 57186 for trunk/src/wp-includes/html-api/class-wp-html-open-elements.php

Timestamp:

12/13/2023 05:51:42 PM (3 years ago)

Author:

Bernhard Reiter

Message:

HTML API: Add support for H1-H6 elements in the HTML Processor.

Previously these have been unsupported, but in this patch, support is added for the tags so that the HTML Processor can process documents containing them.

There was a design discussion about introducing a constant to communicate "any of the H1 - H6 elements" but this posed a number of challenges that don't need to be answered in this patch. For the time being, because the HTML specification treats H1 - H6 specially as a single kind of element, the HTML Processor uses an internal hard-coded string to indicate this. By using a hard-coded string it's possible to avoid introducing a class constant which cannot be made private due to PHP's class design. In the future, this will probably appear as a special constant in a new constant-containing class.

Props dmsnell, jonsurrell.
Fixes #60060.

File:

• trunk/src/wp-includes/html-api/class-wp-html-open-elements.php (modified) (2 diffs)

trunk/src/wp-includes/html-api/class-wp-html-open-elements.php

@@ -114 +114 @@
                 foreach ( $this->walk_up() as $node ) {
                         if ( $node->node_name === $tag_name ) {
+                                return true;
+                        }
+
+                        if (
+                                '(internal: H1 through H6 - do not use)' === $tag_name &&
+                                in_array( $node->node_name, array( 'H1', 'H2', 'H3', 'H4', 'H5', 'H6' ), true )
+                        ) {
                                 return true;
                         }
@@ -271 +278 @@
                         $this->pop();
 
+                        if (
+                                '(internal: H1 through H6 - do not use)' === $tag_name &&
+                                in_array( $item->node_name, array( 'H1', 'H2', 'H3', 'H4', 'H5', 'H6' ), true )
+                        ) {
+                                return true;
+                        }
+
                         if ( $tag_name === $item->node_name ) {
                                 return true;