Changeset 572 in tests

Timestamp:

03/13/2012 10:24:08 PM (14 years ago)

Author:

kurtpayne

Message:

Cache results of isTracTicketClosed

File:

• wp-testlib/base.php (modified) (1 diff)

wp-testlib/base.php

@@ -396 +396 @@
          */
         function isTracTicketClosed($trac_url, $ticket_id) {
-                #TODO: cache it
+                global $trac_ticket_cache;
+                if ( !isset( $trac_ticket_cache ) || !is_array( $trac_ticket_cache ))
+                        $trac_ticket_cache = array();
                 $trac_url = rtrim($trac_url, '/');
-                $ticket_tsv = file_get_contents("$trac_url/ticket/$ticket_id?format=tab");
+                $url = "$trac_url/ticket/$ticket_id?format=tab";                
+                if ( array_key_exists( $url, $trac_ticket_cache ) ) {
+                        return $trac_ticket_cache[$url];
+                }
+                $ticket_tsv = file_get_contents($url);          
                 if (false === $ticket_tsv) {
-                        return null;
+                        $trac_ticket_cache[$url] = null;
+                        return $trac_ticket_cache[$url];
                 }
                 $lines = explode("\n", $ticket_tsv, 2);
                 if (!is_array($lines) || count($lines) < 2) {
-                        return null;
+                        $trac_ticket_cache[$url] = null;
+                        return $trac_ticket_cache[$url];
                 }
                 $titles = str_getcsv( $lines[0], "\t" );
                 $status_idx = array_search('status', $titles);
                 if (false === $status_idx) {
-                        return null;
+                        $trac_ticket_cache[$url] = null;
+                        return $trac_ticket_cache[$url];
                 }
                 $tabs = str_getcsv( $lines[1], "\t" );
-                return 'closed' === $tabs[$status_idx];
+                $trac_ticket_cache[$url] = ( 'closed' === $tabs[$status_idx] );
+                return $trac_ticket_cache[$url];
         }