Changeset 57212 for trunk/.github/workflows/performance.yml

Timestamp:

12/20/2023 06:44:57 PM (17 months ago)

Author:

desrosj

Message:

Build/Test Tools: Raise minimum required version of Node.js/npm.

This bumps the minimum required version of Node.js/npm from 16.19.1 and 8.19.3 to 20.10.0 and 10.2.3.

Since 20.10.0 is the latest 20.x version of Node.js, the check-latest option has been enabled for actions/setup-node in GitHub Actions workflows. This performs an additional external call to the Node.js API confirming the latest version is installed on the runner for use. In testing, it seems that 20.10.0 was not consistently deployed to all runner machines in use. This should be removed in the near future when the version of Node.js is reliably above the new minimum requirement.

The Gutenberg repository has also been updated to use the same values for engines.

Props jorbin, joemcgill, swissspidy, benharri, dhrupo, flootr, gziolo, noahtallen.
See #59663.

File:

• trunk/.github/workflows/performance.yml (modified) (4 diffs)

trunk/.github/workflows/performance.yml

@@ -72 +72 @@
   # - Print performance tests results.
   # - Check out target commit (target branch or previous commit).
+  # - Switch Node.js versions if necessary.
   # - Install npm dependencies.
   # - Build WordPress.
@@ -78 +79 @@
   # - Print target performance tests results.
   # - Reset to original commit.
+  # - Switch Node.js versions if necessary.
   # - Install npm dependencies.
   # - Set the environment to the baseline version.
@@ -191 +193 @@
           git reset --hard $TARGET_SHA
 
+      - name: Set up Node.js
+        uses: actions/setup-node@5e21ff4d9bc1a8cf6de233a3057d20ec6b3fb69d # v3.8.1
+        with:
+          node-version-file: '.nvmrc'
+          cache: npm
+
       - name: Install npm dependencies
         run: npm ci
@@ -212 +220 @@
       - name: Reset to original commit
         run: git reset --hard $GITHUB_SHA
+
+      - name: Set up Node.js
+        uses: actions/setup-node@5e21ff4d9bc1a8cf6de233a3057d20ec6b3fb69d # v3.8.1
+        with:
+          node-version-file: '.nvmrc'
+          cache: npm
 
       - name: Install npm dependencies