Changeset 57215 for trunk/src/wp-includes/block-template-utils.php

Timestamp:

12/20/2023 08:00:04 PM (2 years ago)

Author:

joemcgill

Message:

Themes: Improve the performance of _get_block_templates_paths.

This avoids redundant recursive lookups for block template paths in the same base directory by implementing a static cache. It also replaces an potentially expensive file_exists call in favor of doing recursive iteration of files inside a try/catch block.

Props thekt12, spacedmonkey, flixos90, mukesh27, joemcgill.
Fixes #58196.

File:

• trunk/src/wp-includes/block-template-utils.php (modified) (2 diffs)

trunk/src/wp-includes/block-template-utils.php

@@ -225 +225 @@
  */
 function _get_block_templates_paths( $base_directory ) {
+    static $template_path_list = array();
+    if ( isset( $template_path_list[ $base_directory ] ) ) {
+        return $template_path_list[ $base_directory ];
+    }
     $path_list = array();
-    if ( file_exists( $base_directory ) ) {
+    try {
         $nested_files      = new RecursiveIteratorIterator( new RecursiveDirectoryIterator( $base_directory ) );
         $nested_html_files = new RegexIterator( $nested_files, '/^.+\.html$/i', RecursiveRegexIterator::GET_MATCH );
@@ -232 +236 @@
             $path_list[] = $path;
         }
-    }
+    } catch ( Exception $e ) {
+        // Do nothing.
+    }
+    $template_path_list[ $base_directory ] = $path_list;
     return $path_list;
 }