Changeset 57222 for trunk/tests/phpunit/tests/rest-api/wpRestTemplateRevisionsController.php

Timestamp:

12/22/2023 02:10:18 AM (16 months ago)

Author:

isabel_brison

Message:

REST API: check parent and revision ids match before retrieving revision.

Adds a condition to check that parent id matches revision parent id in WP_REST_Revisions_Controller get_item method.

Props ramonopoly, adamsilverstein, danielbachhuber, spacedmonkey, andrewserong.
Fixes #59875.

File:

• trunk/tests/phpunit/tests/rest-api/wpRestTemplateRevisionsController.php (modified) (4 diffs)

trunk/tests/phpunit/tests/rest-api/wpRestTemplateRevisionsController.php

@@ -23 +23 @@
      * @var string
      */
+    const TEMPLATE_NAME_2 = 'my_template_2';
+
+    /**
+     * @var string
+     */
     const PARENT_POST_TYPE = 'wp_template';
 
@@ -51 +56 @@
      */
     private static $template_post;
+
+    /**
+     * Template post.
+     *
+     * @since 6.5.0
+     *
+     * @var WP_Post
+     */
+    private static $template_post_2;
 
     /**
@@ -124 +138 @@
             )
         );
+
+        // Create a new template post to test the get_item method.
+        self::$template_post_2 = $factory->post->create_and_get(
+            array(
+                'post_type'    => self::PARENT_POST_TYPE,
+                'post_name'    => self::TEMPLATE_NAME_2,
+                'post_title'   => 'My Template 2',
+                'post_content' => 'Content 2',
+                'post_excerpt' => 'Description of my template 2',
+                'tax_input'    => array(
+                    'wp_theme' => array(
+                        self::TEST_THEME,
+                    ),
+                ),
+            )
+        );
+        wp_set_post_terms( self::$template_post_2->ID, self::TEST_THEME, 'wp_theme' );
+
+        var_dump( self::$template_post->ID );
+        var_dump( self::$template_post_2->ID );
     }
 
@@ -335 +369 @@
         $response = rest_get_server()->dispatch( $request );
         $this->assertErrorResponse( 'rest_post_invalid_parent', $response, WP_Http::NOT_FOUND );
+    }
+
+    /**
+     * @ticket 59875
+     */
+    public function test_get_item_invalid_parent_id() {
+        wp_set_current_user( self::$admin_id );
+        $revisions   = wp_get_post_revisions( self::$template_post, array( 'fields' => 'ids' ) );
+        $revision_id = array_shift( $revisions );
+
+        $request = new WP_REST_Request( 'GET', '/wp/v2/templates/' . self::TEST_THEME . '/' . self::TEMPLATE_NAME_2 . '/revisions/' . $revision_id );
+
+        $response = rest_get_server()->dispatch( $request );
+        $this->assertErrorResponse( 'rest_revision_parent_id_mismatch', $response, 404 );
+
+        $expected_message = 'The revision does not belong to the specified parent with id of "' . self::$template_post_2->ID . '"';
+        $this->assertSame( $expected_message, $response->as_error()->get_error_messages()[0], 'The message must contain the correct parent ID.' );
     }