Changeset 57251 for trunk/src/wp-includes/taxonomy.php

Timestamp:

01/08/2024 10:42:49 PM (9 months ago)

Author:

SergeyBiryukov

Message:

Taxonomy: Check for empty term after DB sanitization in wp_insert_term().

When inserting a new term in the database, wp_insert_term() will check if the term is empty and return a corresponding error.

Afterwards the term is sanitized and inserted in the database. However, there is a chance the term is empty after the DB sanitization.

This commit adds a check for an empty term name after the term is sanitized, returning an error in that case.

Follow-up to [5726], [8393].

Props fgiannar, kraftbj.
Fixes #59995.

File:

• trunk/src/wp-includes/taxonomy.php (modified) (1 diff)

trunk/src/wp-includes/taxonomy.php

@@ -2435 +2435 @@
     $parent      = (int) $args['parent'];
 
+    // Sanitization could clean the name to an empty string that must be checked again.
+    if ( '' === $name ) {
+        return new WP_Error( 'invalid_term_name', __( 'Invalid term name.' ) );
+    }
+
     $slug_provided = ! empty( $args['slug'] );
     if ( ! $slug_provided ) {