Changeset 57252

Timestamp:

01/08/2024 11:17:48 PM (4 months ago)

Author:

jorbin

Message:

Upgrade/Install: Check theme compatibility during bulk upgrades.

Previously, bulk upgrades did not verify that a theme package was compatible with the site's WordPress version or the server's PHP version.

This was previusly done for plugins in #59198, but themes were missed.

Follow-up to: [56525].

Props salcode, lakshmananphp.
Fixes #59758.

File:

• trunk/src/wp-admin/includes/class-theme-upgrader.php (modified) (3 diffs)

trunk/src/wp-admin/includes/class-theme-upgrader.php

@@ -372 +372 @@
      * @since 3.7.0 The `$args` parameter was added, making clearing the update cache optional.
      *
+     * @global string $wp_version The WordPress version string.
+     *
      * @param string[] $themes Array of the theme slugs.
      * @param array    $args {
@@ -382 +384 @@
      */
     public function bulk_upgrade( $themes, $args = array() ) {
+        global $wp_version;
+
         $defaults    = array(
             'clear_update_cache' => true,
@@ -443 +447 @@
             $r = $current->response[ $theme ];
 
-            $result = $this->run(
-                array(
-                    'package'           => $r['package'],
-                    'destination'       => get_theme_root( $theme ),
-                    'clear_destination' => true,
-                    'clear_working'     => true,
-                    'is_multi'          => true,
-                    'hook_extra'        => array(
-                        'theme'       => $theme,
-                        'temp_backup' => array(
-                            'slug' => $theme,
-                            'src'  => get_theme_root( $theme ),
-                            'dir'  => 'themes',
+            if ( isset( $r['requires'] ) && ! is_wp_version_compatible( $r['requires'] ) ) {
+                $result = new WP_Error(
+                    'incompatible_wp_required_version',
+                    sprintf(
+                        /* translators: 1: Current WordPress version, 2: WordPress version required by the new theme version. */
+                        __( 'Your WordPress version is %1$s, however the new theme version requires %2$s.' ),
+                        $wp_version,
+                        $r['requires']
+                    )
+                );
+
+                $this->skin->before( $result );
+                $this->skin->error( $result );
+                $this->skin->after();
+            } elseif ( isset( $r['requires_php'] ) && ! is_php_version_compatible( $r['requires_php'] ) ) {
+                $result = new WP_Error(
+                    'incompatible_php_required_version',
+                    sprintf(
+                        /* translators: 1: Current PHP version, 2: PHP version required by the new theme version. */
+                        __( 'The PHP version on your server is %1$s, however the new theme version requires %2$s.' ),
+                        PHP_VERSION,
+                        $r['requires_php']
+                    )
+                );
+
+                $this->skin->before( $result );
+                $this->skin->error( $result );
+                $this->skin->after();
+            } else {
+                add_filter( 'upgrader_source_selection', array( $this, 'check_package' ) );
+                $result = $this->run(
+                    array(
+                        'package'           => $r['package'],
+                        'destination'       => get_theme_root( $theme ),
+                        'clear_destination' => true,
+                        'clear_working'     => true,
+                        'is_multi'          => true,
+                        'hook_extra'        => array(
+                            'theme'       => $theme,
+                            'temp_backup' => array(
+                                'slug' => $theme,
+                                'src'  => get_theme_root( $theme ),
+                                'dir'  => 'themes',
+                            ),
                         ),
-                    ),
-                )
-            );
+                    )
+                );
+                remove_filter( 'upgrader_source_selection', array( $this, 'check_package' ) );
+            }
 
             $results[ $theme ] = $result;