Changeset 57294

Timestamp:

01/16/2024 05:01:30 PM (13 months ago)

Author:

flixos90

Message:

Media: Consider inline image CSS width to backfill width and height attributes.

Prior to this changeset, WordPress core would use the original image size, which in the particular case of inline images would be severely off, as they are usually very small. This could lead to incorrect application of fetchpriority="high" and other performance optimizations.

Props westonruter, flixos90, joemcgill, mukesh27.
Fixes #59352.

Location:

trunk

Files:

• src/wp-includes/media.php (modified) (1 diff)
• tests/phpunit/tests/media/wpImgTagAddWidthAndHeightAttr.php (added)

trunk/src/wp-includes/media.php

@@ -2118 +2118 @@
 
         if ( $size_array ) {
+            // If the width is enforced through style (e.g. in an inline image), calculate the dimension attributes.
+            $style_width = preg_match( '/style="width:\s*(\d+)px;"/', $image, $match_width ) ? (int) $match_width[1] : 0;
+            if ( $style_width ) {
+                $size_array[1] = (int) round( $size_array[1] * $style_width / $size_array[0] );
+                $size_array[0] = $style_width;
+            }
+
             $hw = trim( image_hwstring( $size_array[0], $size_array[1] ) );
             return str_replace( '<img', "<img {$hw}", $image );