Changeset 57319

Timestamp:

01/20/2024 12:13:19 AM (12 months ago)

Author:

dmsnell

Message:

HTML API: Cleanup tests and list of void elements.

This patch adds newly supported elements to tests that should have been updated
in recent PRs, but which were merged without that. Those PRs removed failing
tests showing that the elements were unsupported, but did not add the elements
to the list of supported ones.

It also removes some elements from the special-exclusion list of unsupported IN
BODY elements. These did not present in failing tests because earlier
conditions in the switch structure caught the tags before hitting the default
block.

Finally it adds some missing elements to the list of void elements. These
elements are not listed as void in the HTML specification because they are
deprecated. However, they are treated as void for the sake of HTML
serialization and the parsing rules indicate that they behave as void elements,
so it's safe to list them within the HTML API as void.

Developed in WordPress/wordpress-develop#5913

Fixes #60307

Location:

trunk

Files:

• src/wp-includes/html-api/class-wp-html-processor.php (modified) (7 diffs)
• tests/phpunit/tests/html-api/wpHtmlProcessorBreadcrumbs.php (modified) (6 diffs)

trunk/src/wp-includes/html-api/class-wp-html-processor.php

@@ -1003 +1003 @@
         switch ( $tag_name ) {
             case 'APPLET':
-            case 'AREA':
             case 'BASE':
             case 'BASEFONT':
@@ -1011 +1010 @@
             case 'COL':
             case 'COLGROUP':
-            case 'DD':
-            case 'DT':
             case 'FORM':
             case 'FRAME':
@@ -1020 +1017 @@
             case 'IFRAME':
             case 'INPUT':
-            case 'LI':
             case 'LINK':
             case 'MARQUEE':
@@ -1030 +1026 @@
             case 'NOSCRIPT':
             case 'OBJECT':
-            case 'OL':
             case 'OPTGROUP':
             case 'OPTION':
@@ -1056 +1051 @@
             case 'TR':
             case 'TRACK':
-            case 'UL':
             case 'XMP':
                 $this->last_error = self::ERROR_UNSUPPORTED;
@@ -1710 +1704 @@
             'AREA' === $tag_name ||
             'BASE' === $tag_name ||
+            'BASEFONT' === $tag_name || // Obsolete but still treated as void.
+            'BGSOUND' === $tag_name || // Obsolete but still treated as void.
             'BR' === $tag_name ||
             'COL' === $tag_name ||
             'EMBED' === $tag_name ||
+            'FRAME' === $tag_name ||
             'HR' === $tag_name ||
             'IMG' === $tag_name ||
@@ -1719 +1716 @@
             'KEYGEN' === $tag_name || // Obsolete but still treated as void.
             'META' === $tag_name ||
+            'PARAM' === $tag_name || // Obsolete but still treated as void.
             'SOURCE' === $tag_name ||
             'TRACK' === $tag_name ||

trunk/tests/phpunit/tests/html-api/wpHtmlProcessorBreadcrumbs.php

@@ -41 +41 @@
             'ACRONYM', // Neutralized.
             'ADDRESS',
+            'AREA',
             'ARTICLE',
             'ASIDE',
@@ -49 +50 @@
             'BIG',
             'BLINK', // Deprecated.
+            'BR',
             'BUTTON',
             'CANVAS',
@@ -66 +68 @@
             'DT',
             'EM',
+            'EMBED',
             'FIELDSET',
             'FIGCAPTION',
@@ -79 +82 @@
             'HEADER',
             'HGROUP',
+            'HR',
             'I',
             'IMG',
             'INS',
             'LI',
-            'ISINDEX', // Deprecated
+            'ISINDEX', // Deprecated.
             'KBD',
+            'KEYGEN', // Deprecated.
             'LABEL',
             'LEGEND',
+            'LISTING', // Deprecated.
             'MAIN',
             'MAP',
@@ -92 +98 @@
             'MENU',
             'METER',
-            'MULTICOL', // Deprecated
+            'MULTICOL', // Deprecated.
             'NAV',
-            'NEXTID', // Deprecated
+            'NEXTID', // Deprecated.
             'OL',
             'OUTPUT',
@@ -107 +113 @@
             'SLOT',
             'SMALL',
-            'SPACER', // Deprecated
+            'SPACER', // Deprecated.
             'SPAN',
             'STRIKE',