Changeset 57329 for trunk/src/wp-includes/block-supports/typography.php

Timestamp:

01/23/2024 05:55:49 AM (16 months ago)

Author:

isabel_brison

Message:

Editor: fix fluid font division by zero error when min and max viewport widths are equal.

Fixes a division error by returning null when minViewportWidth - maxViewportWidth is zero in wp_get_computed_fluid_typography_value.

Props ramonopoly, mukesh27, andrewserong, audrasjb.
Fixes #60263.

File:

• trunk/src/wp-includes/block-supports/typography.php (modified) (3 diffs)

trunk/src/wp-includes/block-supports/typography.php

@@ -399 +399 @@
  * @since 6.1.0
  * @since 6.3.0 Checks for unsupported min/max viewport values that cause invalid clamp values.
+ * @since 6.5.0 Returns early when min and max viewport subtraction is zero to avoid division by zero.
  * @access private
  *
@@ -469 +470 @@
     }
 
+    // Calculates the linear factor denominator. If it's 0, we cannot calculate a fluid value.
+    $linear_factor_denominator = $maximum_viewport_width['value'] - $minimum_viewport_width['value'];
+    if ( empty( $linear_factor_denominator ) ) {
+        return null;
+    }
+
     /*
      * Build CSS rule.
@@ -474 +481 @@
      */
     $view_port_width_offset = round( $minimum_viewport_width['value'] / 100, 3 ) . $font_size_unit;
-    $linear_factor          = 100 * ( ( $maximum_font_size['value'] - $minimum_font_size['value'] ) / ( $maximum_viewport_width['value'] - $minimum_viewport_width['value'] ) );
+    $linear_factor          = 100 * ( ( $maximum_font_size['value'] - $minimum_font_size['value'] ) / ( $linear_factor_denominator ) );
     $linear_factor_scaled   = round( $linear_factor * $scale_factor, 3 );
     $linear_factor_scaled   = empty( $linear_factor_scaled ) ? 1 : $linear_factor_scaled;