Changeset 57332

Timestamp:

01/23/2024 08:57:48 AM (11 months ago)

Author:

youknowriad

Message:

Editor: Ensure PHPUnit10 compatibility for ThemeJson unit test.

Expecting E_STRICT, E_NOTICE, and E_USER_NOTICE errors is deprecated in PHPUnit 10.
This updates the test to rely on an exception instead.

Props antonvlasenko.
Fixes #60305.

File:

• trunk/tests/phpunit/tests/theme/wpThemeJson.php (modified) (2 diffs)

trunk/tests/phpunit/tests/theme/wpThemeJson.php

@@ -4282 +4282 @@
      */
     public function test_set_spacing_sizes_should_detect_invalid_spacing_scale( $spacing_scale, $expected_output ) {
-        $this->expectNotice();
-        $this->expectNoticeMessage( 'Some of the theme.json settings.spacing.spacingScale values are invalid' );
+        $this->expectException( Exception::class );
+        $this->expectExceptionMessage( 'Some of the theme.json settings.spacing.spacingScale values are invalid' );
 
         $theme_json = new WP_Theme_JSON(
@@ -4294 +4294 @@
                 ),
             )
+        );
+
+        // Ensure PHPUnit 10 compatibility.
+        set_error_handler(
+            static function ( $errno, $errstr ) {
+                restore_error_handler();
+                throw new Exception( $errstr, $errno );
+            },
+            E_ALL
         );