Changeset 57339 for trunk/tests/phpunit/tests/l10n/wpTranslationController.php

Timestamp:

01/23/2024 03:13:32 PM (3 years ago)

Author:

swissspidy

Message:

I18N: Improve edge case handling in WP_Translation_Controller.

Prevents PHP warnings for possibly undefined array keys.
Also fixes incorrect @covers annotations.

Follow-up to [57337].
See #59656.

File:

• trunk/tests/phpunit/tests/l10n/wpTranslationController.php (modified) (2 diffs)

trunk/tests/phpunit/tests/l10n/wpTranslationController.php

@@ -111 +111 @@
          * @return void
          */
+        public function test_load_textdomain_prefers_php_files_by_default() {
+                $load_successful = load_textdomain( 'wp-tests-domain', DIR_TESTDATA . '/pomo/simple.mo' );
+
+                $instance = WP_Translation_Controller::instance();
+
+                $is_loaded = $instance->is_textdomain_loaded( 'wp-tests-domain', 'en_US' );
+
+                $unload_mo  = $instance->unload_file( DIR_TESTDATA . '/pomo/simple.mo', 'wp-tests-domain' );
+                $unload_php = $instance->unload_file( DIR_TESTDATA . '/pomo/simple.l10n.php', 'wp-tests-domain' );
+
+                $unload_successful = unload_textdomain( 'wp-tests-domain' );
+
+                $this->assertTrue( $load_successful, 'Translation not successfully loaded' );
+                $this->assertTrue( $is_loaded );
+                $this->assertFalse( $unload_mo );
+                $this->assertTrue( $unload_php );
+                $this->assertTrue( $unload_successful );
+        }
+
+        /**
+         * @covers ::load_textdomain
+         *
+         * @return void
+         */
         public function test_load_textdomain_reads_php_files_if_filtered_format_is_unsupported() {
                 add_filter(
@@ -298 +322 @@
 
         /**
+         * @covers ::unload_file
+         * @covers ::unload_textdomain
+         *
+         * @return void
+         */
+        public function test_unload_non_existent_files_and_textdomains() {
+                $controller = new WP_Translation_Controller();
+                $this->assertFalse( $controller->unload_textdomain( 'foobarbaz' ) );
+                $this->assertFalse( $controller->unload_textdomain( 'foobarbaz', 'es_ES' ) );
+                $this->assertFalse( $controller->unload_textdomain( 'default', 'es_ES' ) );
+                $this->assertFalse( $controller->unload_file( DIR_TESTDATA . '/l10n/fa_IR.mo' ) );
+                $this->assertFalse( $controller->unload_file( DIR_TESTDATA . '/l10n/fa_IR.mo', 'es_ES' ) );
+        }
+
+        /**
          * @covers ::load_textdomain
          * @covers ::unload_textdomain