Changeset 57341 for trunk/src/wp-includes/script-loader.php

Timestamp:

01/23/2024 05:54:25 PM (12 months ago)

Author:

westonruter

Message:

Script Loader: Only emit CDATA wrapper comments in wp_get_inline_script_tag() for JavaScript.

This avoids erroneously adding CDATA wrapper comments for non-JavaScript scripts, including those for JSON such as the importmap for script modules in #56313.

Props westonruter, flixos90, mukesh27, dmsnell.
See #56313.
Fixes #60320.

File:

• trunk/src/wp-includes/script-loader.php (modified) (1 diff)

trunk/src/wp-includes/script-loader.php

@@ -2880 +2880 @@
      * @see https://www.w3.org/TR/xhtml1/#h-4.8
      */
-    if ( ! $is_html5 ) {
+    if (
+        ! $is_html5 &&
+        (
+            ! isset( $attributes['type'] ) ||
+            'module' === $attributes['type'] ||
+            str_contains( $attributes['type'], 'javascript' ) ||
+            str_contains( $attributes['type'], 'ecmascript' ) ||
+            str_contains( $attributes['type'], 'jscript' ) ||
+            str_contains( $attributes['type'], 'livescript' )
+        )
+    ) {
         /*
          * If the string `]]>` exists within the JavaScript it would break